Skip to content

Log warning when GetGradientForOp() silently fails. #6586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrry merged 2 commits into from
Feb 10, 2021
Merged

Log warning when GetGradientForOp() silently fails. #6586

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5295193
Add warning when GetGradientForOp() silently fails.
Feb 5, 2021
5bd6713
Fix incorrect LOG macro.
Feb 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion orttraining/orttraining/core/framework/gradient_graph_builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,11 @@ Status GradientGraphBuilder::Build(const std::unordered_set<std::string>* p_init
}

GradientDef node_defs = GetGradientForOp(gradient_graph_config_, graph_, node, output_args_need_grad, input_args_need_grad, logger_);

if (node_defs.empty()) {
LOGS(logger_, WARNING) << "GetGradientForOp() did not create any nodes for node "
<< node->Name() << " of type " << node->OpType() << ".";
}

// updates arg name if gradient accumulation is needed
for (auto& op_def : node_defs) {
for (auto& arg : op_def.output_args) {
Expand Down