Generate shape-independent graph if any input dimension < 2 #6581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschin
changed the title
|
|
||
| if (A_has_shape && B_has_shape && Y_has_shape) { | ||
| if (A_has_shape && B_has_shape && Y_has_shape && | ||
| A_shape.size() >= 2 && B_shape.size() >= 2) { |
Contributor
There was a problem hiding this comment.
Matmul schema only allow inputs with dim>=2.
I thought this is an implicit prerequisite? Are you seeing inputs with less then 2 dim?
Contributor
There was a problem hiding this comment.
I saw the discussion on team's channel, and understand now this is caused by a torch bug/"feature".
This fix is harmless.
Member
There was a problem hiding this comment.
SherlockNoMad
approved these changes
Feb 5, 2021
Contributor
|
/azp run Windows CPU CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.