Switch Android CI java build to JDK 11 #6552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuslepukhin
reviewed
Feb 3, 2021
| - script: python3 tools/ci_build/build.py --android --build_dir build --android_sdk_path $ANDROID_HOME --android_ndk_path $ANDROID_HOME/ndk-bundle --android_abi=x86_64 --android_api=29 --skip_submodule_sync --parallel --cmake_generator=Ninja --build_java | ||
| # Start switching to jdk 11 after the Android Emulator is started since Android SDK manager requires java 8 | ||
| - task: JavaToolInstaller@0 |
Member
There was a problem hiding this comment.
task: JavaToolInstaller@0 [](start = 4, length = 25)
Will this execute once?
Contributor
Author
There was a problem hiding this comment.
Yes, this task is actually setting the environment variables
Contributor
|
We could switch the regular Java build to 11 too, and target the Java 8 release to ensure compatibility. |
snnn
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Switch Android CI java build to JDK 11
Motivation and Context