Skip to content

Conversation

@ryanlai2
Copy link
Contributor

@ryanlai2 ryanlai2 commented Feb 2, 2021

Runtime error telemetry should only be sent out for scenarios where WinML behaved in an unexpected incorrect way.

In the scenario, that there are no hardware adapters available and a LearningModelDevice targetting GPU can't be created, Runtime error telemetry shouldn't be sent but hresult error should still be returned to the client app.

TelemetryFallback callback function that calls LogRuntimeError for any failure can be removed for these reasons:

  • WinML "THROW_IF_FAILED" macros already call LogRuntimeError, no need to send error telemetry twice.
  • The telemetry data sent by this callback function doesn't contain line and file information.
  • Having this prevents WinML from throwing error without sending telemetry.

@ryanlai2 ryanlai2 requested a review from a team as a code owner February 2, 2021 08:05
@ryanlai2 ryanlai2 merged commit c7feb48 into master Feb 3, 2021
@ryanlai2 ryanlai2 deleted the user/rylai/no_telemetry_for_no_hardware_adapters branch February 3, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants