[CoreML EP] Add support of Conv operator #6510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skottmckay
reviewed
Feb 3, 2021
skottmckay
reviewed
Feb 3, 2021
onnxruntime/core/providers/coreml/builders/impl/conv_op_builder.cc
Outdated
Show resolved
Hide resolved
skottmckay
reviewed
Feb 3, 2021
skottmckay
reviewed
Feb 3, 2021
| size_t num_elements = std::accumulate(dimensions.begin(), dimensions.end(), 1, std::multiplies<size_t>()); | ||
| return num_elements * GetElementByteSize(); | ||
| return SafeInt<size_t>(num_elements * GetElementByteSize()); | ||
| } |
Contributor
There was a problem hiding this comment.
I think you need to convert one to a SafeInt prior to doing the calculation. Otherwise you're putting the result of the calculation in the SafeInt and any overflow has already happened.
e.g. SafeInt<size_t>(num_elements) * GetElementByteSize(); #Closed
Contributor
Author
There was a problem hiding this comment.
But isn't num_elements already a size_t? Do we need the SafeInt call here at all? #Closed
Contributor
There was a problem hiding this comment.
The SafeInt will check if the size_t overflows when num_elements is multiplied by GetElementByteSize(). more likely on a 32-bit system where size_t is smaller.
In reply to: 569776202 [](ancestors = 569776202)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: [CoreML EP] Add support of Conv operator
Motivation and Context