Fix CUDA Reduction kernel for ArgMax/ArgMix for when reduction dim=1 #6490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashbhandare
added
core runtime
weixingzhang
previously approved these changes
Jan 28, 2021
jessebenson
previously approved these changes
Jan 29, 2021
weixingzhang
approved these changes
Feb 2, 2021
jessebenson
added a commit
that referenced
this pull request
Feb 3, 2021
jessebenson
added a commit
that referenced
this pull request
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cudnnReduceTensor errors out CUDNN_STATUS_BAD_PARAM when the corresponding dimensions of the input and output tensors all match. This will happen if the dimension of the axis to be reduced is 1. This change fixes the issue.
Fixes #6482