Skip to content

Conversation

@snnn
Copy link
Contributor

@snnn snnn commented Jan 28, 2021

Description:

  1. Merge Nuget CPU pipeline, Java CPU pipeline, C-API pipeline into a single one.
  2. Enable compile warnings for cuda files(*.cu) on Windows.
  3. Enable static code analyze for the Windows builds in these jobs. For example, this is our first time scanning the JNI code.
  4. Fix some warnings in the training code.
  5. Enable code sign for Java. Previously we forgot it.
  6. Update TPN.txt to remove Jemalloc.

Motivation and Context

  • Why is this change required? What problem does it solve?

Instead of building onnxruntime.dll multiple times for each language binding, we should build it only once, the reuse the result. It will be easier for us to maintain the build flags consistent across different language bindings, also reduce the total build time. Also, it's easier to setup the security checks.

  • If it fixes an open issue, please link to the issue here.

@snnn snnn requested a review from a team as a code owner January 28, 2021 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants