Add hipFFT include directory (transitional step) before ROCm. #5992
Conversation
hipFFT is transitioning to a separate repository (away from being included in rocFFT). During this transition, using the hipFFT version of hipfft.h won't produce a deprecation warning.
|
Will hipfft.h exist in both ROCM include path and the separate path during the transition? |
|
Yes, hipfft.h will exist in two places during the transition. One version will have the deprecation warning, the other will not. |
|
when will this transition be done? ROCm EP are not using FFT now. |
|
@weixingzhang We don't have a specific date in mind. We put in the deprecation warning and will let that percolate for a few months. Once the dust settles we will finish the transition. I realize this is a vague answer; if you need a more concrete answer please let me know! |
|
@weixingzhang We tested this PR with multiple ROCm release internally and it is approved as fine. Can you let it merge to ToT? |
The CI pipeline hasn't been triggered. Let me trigger the CI test. |
|
/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux CPU x64 NoContribops CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, MacOS NoContribops CI Pipeline, Windows CPU CI Pipeline |
|
/azp run Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, centos7_cpu, centos7_cpu (linux_centos_ci Debug), centos7_cpu (linux_centos_ci Release), orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-amd-gpu-ci-pipeline |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
Azure Pipelines successfully started running 9 pipeline(s). |
|
/azp run orttraining-distributed, Linux Nuphar CI Pipeline |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Can this PR be merged now? |
Just merged. Thanks! |
hipFFT is transitioning to a separate repository (away from being included in rocFFT). During this transition, using the hipFFT version of hipfft.h won't produce a deprecation warning.
5 participants
hipFFT is transitioning to a separate repository (away from being
included in rocFFT). During this transition, using the hipFFT version
of hipfft.h won't produce a deprecation warning.