Support Windows cross-compiling for ARM(64) in ORT build scripts #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snnn
reviewed
Mar 6, 2019
snnn
reviewed
Mar 6, 2019
Contributor
snnn
left a comment
snnn
left a comment
There was a problem hiding this comment.
For anything you are changing, please don't forget to update https://github.com/Microsoft/onnxruntime/blob/master/BUILD.md#cross-compiling-on-linuxfaster
hariharans29
changed the title
hariharans29
changed the title
hariharans29
changed the title
Member
Author
|
Sample Windows ARM(32) build - https://dev.azure.com/onnxruntime/onnxruntime/_build/results?buildId=9570 Sample ARM64 build - https://dev.azure.com/onnxruntime/onnxruntime/_build/results?buildId=9589 |
snnn
reviewed
Mar 8, 2019
tools/ci_build/build.py
Outdated
| if pb_home: | ||
| cmake_args += ["-DONNX_CUSTOM_PROTOC_EXECUTABLE=" + os.path.join(pb_home,'bin','protoc'), '-Donnxruntime_USE_PREBUILT_PB=ON'] | ||
|
|
||
| if not pb_home and path_to_protoc_exe: |
snnn
reviewed
Mar 8, 2019
snnn
previously approved these changes
Mar 8, 2019
snnn
previously approved these changes
Mar 8, 2019
snnn
approved these changes
Mar 8, 2019
xiaofeihan1
added a commit
that referenced
this pull request
Jan 23, 2026
Some PRs that use core/common/inlined_containers.h can cause failures in the CUDA CI pipeline. ``` E:\_work\_temp\build\RelWithDebInfo\vcpkg_installed\x64-windows-static-md\include\absl/hash/internal/hash.h(481): error #68-D: integer conversion resulted in a change of sign [E:\_work\_temp\build\RelWithDebInfo\onnxruntime_providers_cuda.vcxproj] sizeof(T) == -1, ^ Remark: The warnings can be suppressed with "-diag-suppress <warning-number>" E:\_work\_temp\build\RelWithDebInfo\vcpkg_installed\x64-windows-static-md\include\absl/hash/hash.h(337): error #549-D: variable "s" is used before its value is set [E:\_work\_temp\build\RelWithDebInfo\onnxruntime_providers_cuda.vcxproj] return s; ^ E:\_work\_temp\build\RelWithDebInfo\vcpkg_installed\x64-windows-static-md\include\absl/container/internal/raw_hash_set.h(468): error #69-D: integer conversion resulted in truncation [E:\_work\_temp\build\RelWithDebInfo\onnxruntime_providers_cuda.vcxproj] static_cast<uint16_t>(reinterpret_cast<uintptr_t>(&seed)); ^ 3 errors detected in the compilation of "E:/_work/onnxruntime/onnxruntime/onnxruntime/contrib_ops/cuda/sparse/block_mask.cu". ``` This change adds a patch to Abseil to mitigate those failures. This solution has been verified to be effective in PR #27087.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.