-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Allow sharing of initializers between sessions. #5092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3cb779 to
b42d231
Compare
RandySheriffH
previously approved these changes
Sep 10, 2020
skottmckay
reviewed
Sep 10, 2020
skottmckay
reviewed
Sep 10, 2020
skottmckay
reviewed
Sep 10, 2020
skottmckay
reviewed
Sep 10, 2020
cf29976 to
997ff10
Compare
Moved AddInitializer logic to internal session options Added tests for owned buffer Clarified documentation Fix bug where memory info and not device was getting compared
997ff10 to
1307db6
Compare
snnn
previously approved these changes
Sep 19, 2020
skottmckay
reviewed
Sep 21, 2020
skottmckay
reviewed
Sep 21, 2020
skottmckay
reviewed
Sep 21, 2020
skottmckay
approved these changes
Sep 21, 2020
Contributor
skottmckay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Allow sharing of initializers between sessions.
NB: This is not intended for 1.5 release.
Motivation and Context
LUIS team produces many models that share the initializers. They would like the ability to share them across sessions for efficiency. They've tested the changes e2e.
Design: https://microsoft-my.sharepoint.com/:w:/p/prs/EUi_AfiH5RNMtkO3up6hndYBoICNa4GWyu9Mp7It8k-Yzw?e=xVfF5L