Skip to content

Use OpenMP-like synchronization patterns in Eigen thread pool #4236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlh20 merged 12 commits into from
Jun 22, 2020
Merged

Use OpenMP-like synchronization patterns in Eigen thread pool #4236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
be89f9d
threading
Jun 11, 2020
997cf66
Bias work distribution toward one item per thread
tlh20 Jun 12, 2020
6ddf34f
Unbreak debug builds
tlh20 Jun 12, 2020
4bcf795
Unbreak debug builds
tlh20 Jun 12, 2020
850c239
Sharded loop counter does not require iteration to be a multiple of b…
tlh20 Jun 12, 2020
4604628
Exit spin loop on done_ flag
tlh20 Jun 12, 2020
07cbf2f
Whitespace clean-up
tlh20 Jun 15, 2020
fe2637f
onnxruntime::make_unique instead of std::make_unique
tlh20 Jun 15, 2020
c19cf71
Updates for PR comments
tlh20 Jun 16, 2020
d08b3db
Fix Linux builds
tlh20 Jun 16, 2020
0eafefc
Use _MSC_VER in ifdef, rather than absence of __GNUC__
tlh20 Jun 17, 2020
d043bfe
Merge from master for CI updates
tlh20 Jun 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions include/onnxruntime/core/platform/Barrier.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,14 @@ class Barrier {
}
#endif

void Notify() {
unsigned int v = state_.fetch_sub(2, std::memory_order_acq_rel) - 2;
void Notify(unsigned int c = 1) {
unsigned int delta = c << 1;
unsigned int v = state_.fetch_sub(delta, std::memory_order_acq_rel) - delta;
if (v != 1) {
// Clear the lowest bit (waiter flag) and check that the original state
// value was not zero. If it was zero, it means that notify was called
// more times than the original count.
assert(((v + 2) & ~1) != 0);
assert(((v + delta) & ~1) != 0);
return; // either count has not dropped to 0, or waiter is not waiting
}
std::unique_lock<OrtMutex> l(mu_);
Expand Down
Loading