Skip to content

Add remaining build options and make minor changes in documentation #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pranavsharma merged 4 commits into from
Nov 28, 2018
Merged

Add remaining build options and make minor changes in documentation #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f06add7
Minor changes in documentation
Nov 28, 2018
b68f268
Synchronous, not sync
Nov 28, 2018
33ad557
Add remaining build options after mkldnn fix
Nov 28, 2018
8832b8b
Merge remote-tracking branch 'origin/master' into pranav_bug_bash
Nov 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# turn off readability-braces-around-statements to allow single line statement like 'if (x == y) doSomething();'
Checks: '-*,cppcoreguidelines-*,google-*,readability-*,modernize-*,-readability-braces-around-statements,-google-runtime-references,-cppcoreguidelines-pro-type-reinterpret-cast'
WarningsAsErrors: ''
HeaderFilterRegex: '.*lotus\/core\/.*'
HeaderFilterRegex: '.*onnxruntime\/core\/.*'
AnalyzeTemporaryDtors: false
FormatStyle: none
CheckOptions:
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ gen
.vs
TestResults/
.idea/
lotus.egg-info
onnxruntime.egg-info
nuget_root/
.packages/
.vscode/
Expand Down
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ git commit -m "my changes"
git push origin HEAD
```
To request merge into master send a pull request from the web ui
https://github.com/Microsoft/onnxruntime
https://github.com/Microsoft/onnxruntime and add 'Microsoft/onnxruntime' as a reviewer.

New code *must* be accompanied by unit tests.

# Build
Expand Down
3 changes: 1 addition & 2 deletions docs/HighLevelDesign.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ provider).

Conceptually, each partition is reduced to a single fused operator. It is
created by invoking the execution provider's Compile() method and wrap it as a
custom operator. We support both sync and async modes of execution for custom
operators. We also support both strict and non-strict invocations. An execution
custom operator. Currently we support only synchronous mode of execution. An execution
provider exposes its memory allocator, which is used to allocate the input
tensors for the execution provider. The rewriting and partitioning transform the
initial model graph into a new graph composed with operators assigned to either
Expand Down
2 changes: 1 addition & 1 deletion tools/ci_build/github/azure-pipelines/azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
- task: BatchScript@1
inputs:
filename: build.bat
arguments: ' --enable_onnx_tests --use_mkldnn --enable_pybind'
arguments: ' --enable_pybind --use_mkldnn --use_mklml --build_shared_lib --enable_onnx_tests'
workingFolder: "$(Build.SourcesDirectory)"

- task: CmdLine@1
Expand Down