Repository navigation
test fix implemented - #32798
Merged
Scott McKay (skottmckay) merged 1 commit intoSep 26, 2026
Merged
test fix implemented#32798
Conversation
Signed-off-by: melkap01 <melike.kaptan@arm.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused test-only change is safe and introduces no actionable issues.
Review effort: Balanced
Findings: None
What changed in this PR
Stabilizes the Windows-on-ARM KleidiAI HalfGemm boundary test.
Changes:
- Replaces the single-byte output with a sentinel-filled buffer.
- Verifies rejected packing leaves the buffer unchanged.
| File | Description |
|---|---|
onnxruntime/test/mlas/unittest/test_halfgemm.cpp |
Hardens the unsupported-K test buffer and validation. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Xavier Dupré (xadupre)
approved these changes
Sep 25, 2026
Contributor
Author
|
hi, [build_x64_release_xnnpack]job failure looks like an unrelated with the changes, do you think a re-run might help ? |
Scott McKay (skottmckay)
merged commit Sep 26, 2026
cfad0a0
into
microsoft:main
90 of 91 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Faling test on Windows on ARM fixed
Motivation and Context