Repository navigation
Add activation mode to com.microsoft::GatedRMSNorm for SiLU/Swish/Sigmoid across CPU, CUDA, and WebGPU
#32512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kunal-vaishnavi
merged 9 commits into
main
from
copilot/extend-gatedrmsnorm-contrib-operator
Sep 18, 2026
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
669fd66
Initial plan
Copilot 1067580
Add GatedRMSNorm activation attr for silu/swish/sigmoid
Copilot 239cd68
Fix review feedback for GatedRMSNorm activation PR
Copilot 1996f0c
Adjust sigmoid stability test tolerance across EPs
Copilot d54ffa5
Relax sigmoid stability tolerance for cross-platform CI
Copilot 5e1da8b
Update generated contrib docs from doc-gen CI artifact
Copilot bdeacfc
Address remaining GatedRMSNorm review feedback
Copilot 7026bcc
Guard 1024-thread GatedRMSNorm launch by device capability
Copilot 084c94d
Fix GatedRMSNorm test precision and CUDA saturation checks
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
onnxruntime/contrib_ops/bert/linear_attention_gates_common.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| #pragma once | ||
|
|
||
| #include <cstdint> | ||
| #include <string_view> | ||
|
|
||
| #include "core/common/common.h" | ||
|
|
||
| namespace onnxruntime { | ||
| namespace contrib { | ||
|
|
||
| enum class GatedRMSNormActivation : uint8_t { | ||
| kSilu = 0, | ||
| kSigmoid = 1, | ||
| }; | ||
|
|
||
| inline Status ParseGatedRMSNormActivation(std::string_view activation, GatedRMSNormActivation& out) { | ||
| if (activation == "silu" || activation == "swish") { | ||
| out = GatedRMSNormActivation::kSilu; | ||
| return Status::OK(); | ||
| } | ||
|
|
||
| if (activation == "sigmoid") { | ||
| out = GatedRMSNormActivation::kSigmoid; | ||
| return Status::OK(); | ||
| } | ||
|
|
||
| return ORT_MAKE_STATUS(ONNXRUNTIME, INVALID_ARGUMENT, "activation must be one of: silu, swish, sigmoid"); | ||
| } | ||
|
|
||
| inline GatedRMSNormActivation ParseGatedRMSNormActivationOrThrow(std::string_view activation) { | ||
| GatedRMSNormActivation parsed_activation = GatedRMSNormActivation::kSilu; | ||
| ORT_THROW_IF_ERROR(ParseGatedRMSNormActivation(activation, parsed_activation)); | ||
| return parsed_activation; | ||
| } | ||
|
|
||
| } // namespace contrib | ||
| } // namespace onnxruntime |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.