[CUDA] Fix Windows DeepGEMM build errors and warnings - #32485
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
QMoE can still select DeepGEMM on Windows even though its runner implementation is compiled out.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Disables unsupported DeepGEMM compilation on Windows and resolves Windows build warnings.
Changes:
- Gates DeepGEMM sources and call sites.
- Reorders MASM blocks to avoid unwind warnings.
- Replaces deprecated
strerrorusage.
File summaries
| File | Description |
|---|---|
QgemmU8X8KernelAvx2.asm |
Moves processing blocks before the epilogue. |
moe_kernels.cu |
Gates DeepGEMM usage. |
manifest_parser.cc |
Uses std::error_code for messages. |
onnxruntime_providers_cuda.cmake |
Disables in-tree DeepGEMM on Windows. |
onnxruntime_providers_cuda_plugin.cmake |
Disables plugin DeepGEMM on Windows. |
onnxruntime_cuda_source_filters.cmake |
Excludes the implementation source on Windows. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The feature gates are consistent across source selection, compilation, preprocessing, and runtime dispatch, with no unresolved issues found.
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 0 new
- Review effort level: Balanced
Hariharan Seshadri (hariharans29)
approved these changes
Sep 9, 2026
Tianlei Wu (tianleiwu)
enabled auto-merge (squash)
September 9, 2026 00:21
Tianlei Wu (tianleiwu)
deleted the
copilot/windows-cuda-build-fix-main
branch
September 9, 2026 02:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__int128_tand inlineasmUSE_DEEP_GEMMfor the in-tree and plugin CUDA providersstrerrorC4996 warning and MLAS MASM A4032 unwind-offset warningTesting
onnxruntime_providers_cuda_sm90_tmaonnxruntime_providers_cuda_llmmodel_packageonnxruntime_mlasValidated on Windows with CUDA 13.0 and
CMAKE_CUDA_ARCHITECTURES=86-real;120-real. The reported DeepGEMM errors, A4032, and C4996 were absent.