Fix CUDA plugin user stream test lifetime - #32449
Merged
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CUDA plugin segfault in CaptureAndReplayOnUserStream
Fix CUDA plugin user stream test lifetime
Sep 5, 2026
Tianlei Wu (tianleiwu)
marked this pull request as ready for review
September 5, 2026 06:06
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The lifetime ordering is corrected, with no unresolved issues found.
Pull request overview
Ensures caller-owned CUDA streams outlive the graph sessions that use them, preventing teardown crashes.
Changes:
- Scope capture/replay and graph-annotation sessions so they are destroyed before their user streams.
File summaries
| File | Description |
|---|---|
onnxruntime/test/providers/cuda/plugin/cuda_plugin_user_stream_graph_test.cc |
Corrects session and stream destruction order. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Tianlei Wu (tianleiwu)
enabled auto-merge (squash)
September 5, 2026 07:50
Member
|
Copilot fix lint |
Contributor
Author
Targeted |
Xavier Dupré (xadupre)
approved these changes
Sep 6, 2026
Tianlei Wu (tianleiwu)
approved these changes
Sep 7, 2026
Baiju Meswani (baijumeswani)
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
CaptureAndReplayOnUserStreamsegfaulted after stream teardown began draining arena state. The tests destroyed the user stream before the session, violating the required lifetime ordering.