Skip to content

[TRT] Fix trt shape values - #32415

Merged
Xavier Dupré (xadupre) merged 2 commits into
microsoft:mainfrom
toothache:fix-trt-shape-values-v2
Sep 3, 2026
Merged

Xavier Dupré (xadupre) merged 2 commits into
microsoft:mainfrom
toothache:fix-trt-shape-values-v2

Conversation

@toothache

Copy link
Copy Markdown
Member

Description

Fix the TensorRT 10.11+ shape-tensor optimization profile setup by passing the configured optimum and maximum values to their matching  kOPT  and  kMAX  profile selectors.

Motivation and Context

Swapping OPT and MAX can make an valid profile invalid, causing TensorRT engine construction to fail when the configured optimum and maximum values differ.

Pass the configured optimum and maximum shape tensor values to the matching TensorRT 10.11+ profile selectors. Add coverage using distinct minimum, optimum, and maximum values.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the change focused on correcting the TensorRT 10.11+ selector arguments.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 3, 2026 08:31
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@toothache Yateng Hong (toothache) changed the title Fix trt shape values v2 [TRT] Fix trt shape values v2 Sep 3, 2026
@toothache Yateng Hong (toothache) changed the title [TRT] Fix trt shape values v2 [TRT] Fix trt shape values Sep 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Regression coverage with distinct MIN, OPT, and MAX shape-tensor values is missing.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Corrects TensorRT 10.11+ shape-tensor profile selector mappings.

Changes:

  • Passes maximum values to kMAX.
  • Passes optimum values to kOPT in both profile paths.
File summaries
File Description
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc Corrects TensorRT shape-profile value assignments.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc
@xadupre
Xavier Dupré (xadupre) merged commit d46218a into microsoft:main Sep 3, 2026
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants