Prevent Agility SDK use with WebGPU Plugin EP builds - #32380
Merged
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The restriction is correctly enforced, with only a minor CMake indentation cleanup remaining.
Pull request overview
Prevents unsupported Dawn Agility SDK use in WebGPU Plugin EP builds.
Changes:
- Rejects incompatible build-script and direct-CMake configurations.
- Updates CLI help and documentation.
File summaries
| File | Description |
|---|---|
tools/ci_build/build.py |
Adds configuration validation. |
tools/ci_build/build_args.py |
Clarifies CLI restrictions. |
docs/BuildWithDawnAgilitySDK.md |
Documents Plugin EP limitation. |
cmake/external/onnxruntime_external_deps.cmake |
Adds direct-CMake validation. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Edward Chen (edgchen1)
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an explicit check to reject --use_dawn_agility_sdk with --use_webgpu shared_lib. For now, Agility SDK support is limited to local static library builds. PTAL, thanks! Jiajia Qin (@qjia7) Edward Chen (@edgchen1) Jie Chen (@jchen10)