[WebNN] Fix inverted fallback data type support check - #32293
Merged
Dwayne Robinson (fdwr) merged 1 commit intoSep 3, 2026
Merged
Conversation
The guard threw whenever the fallback type WAS supported, so int64->int32 fallback never worked. Add the missing negation.
Contributor
Author
|
Dwayne Robinson (@fdwr), PTAL, thanks! |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes WebNN fallback tensor creation by correctly rejecting only unsupported fallback types.
Changes:
- Negates the fallback support check so supported
int32fallbacks proceed.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Dwayne Robinson (@fdwr), can we land it? |
Contributor
Wanming Lin (@Honry) Sorry, if such gets buried in the GitHub notification noise, feel free to bug me via Teams. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guard threw whenever the fallback type WAS supported, so int64->int32 fallback never worked. Add the missing negation.