Filter display adapters that are using the Microsoft Basic Render Driver - #32006
Merged
Scott McKay (skottmckay) merged 1 commit intoAug 12, 2026
Merged
Conversation
…ver without the software flag being set.
Baiju Meswani (baijumeswani)
approved these changes
Aug 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Filters Windows software-based display adapters from WebGPU device discovery.
Changes:
- Detects Microsoft Basic Render Driver by vendor/device IDs.
- Adds a Windows-specific exclusion test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
onnxruntime/core/platform/windows/device_discovery.cc |
Filters affected Microsoft display adapters. |
onnxruntime/test/platform/device_discovery_test.cc |
Checks discovered GPUs exclude the driver. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Scott McKay (skottmckay)
enabled auto-merge (squash)
August 12, 2026 08:02
Scott McKay (skottmckay)
deleted the
skottmckay/FilterMSBasicRenderDriver
branch
August 12, 2026 11:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Filter display adapters that are using the Microsoft Basic Render Driver without the software flag being set.
Motivation and Context
Prevent WebGPU EP attempting to use software based device.