Add Java setup to Windows x64 QNN CI Pipeline - #29754
Merged
Merged
Conversation
Copies the Java setup step from sibling files windows_webgpu.yml, windows_x64_release_xnnpack.yml, windows_x64_release_build_x64_release.yml. This explicitly ensures that a compatible Java version, rather than relying on the JDK already installed on the self-hosted runner. Otherwise there may be breakages when switching the runner. microsoft#29753
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows x64 QNN CI workflow to explicitly install a compatible JDK via actions/setup-java, avoiding reliance on whatever Java version happens to be preinstalled on the self-hosted runner pool (which can vary when runner pools change).
Changes:
- Add a
Setup Javastep towindows_qnn_x64.yml. - Pin the workflow to Temurin JDK 17 (matching the Java setup used in sibling Windows workflows).
Contributor
Author
|
The Windows x64 QNN CI Pipelines look green: https://github.com/microsoft/onnxruntime/actions/runs/29558936844/job/87819091957?pr=29754 |
tianleiwu
approved these changes
Jul 17, 2026
tianleiwu
enabled auto-merge (squash)
July 17, 2026 07:42
tianleiwu
pushed a commit
that referenced
this pull request
Jul 17, 2026
Copies the Java setup step from sibling files `windows_webgpu.yml`, `windows_x64_release_xnnpack.yml`, `windows_x64_release_build_x64_release.yml` to `windows_qnn_x64.yml`. This explicitly ensures a compatible Java version, rather than relying on the JDK already installed on the self-hosted runner. Otherwise there may be breakages when switching the runner. I believe this will fix the failures in CI for the Windows x64 QNN CI Pipeline. I'm seeing it fail in both an unrelated PR: #29728 https://github.com/microsoft/onnxruntime/actions/runs/29509983398/job/87780661649?pr=29728 and in commits to main: https://github.com/microsoft/onnxruntime/actions/runs/29546572913/job/87780090142 https://github.com/microsoft/onnxruntime/actions/runs/29499730505/job/87625355397 This is assuming the chain of causation: 1. #29731 switches the runner pool 2. The `windows_qnn_x64.yml` pipeline finds JDK 8 already on the runner (previous runner pool had JDK 11) 3. The Spotless Gradle plugin v7.2.1 isn't compatible with JDK 8 4. onnxruntime Java project can't be configured 5. Build fails This new workflow action hopefully installs a compatible JDK & all will be well. #29753
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Copies the Java setup step from sibling files
windows_webgpu.yml,windows_x64_release_xnnpack.yml,windows_x64_release_build_x64_release.ymltowindows_qnn_x64.yml.This explicitly ensures a compatible Java version, rather than relying on the JDK already installed on the self-hosted runner. Otherwise there may be breakages when switching the runner.
Motivation and Context
I believe this will fix the failures in CI for the Windows x64 QNN CI Pipeline. I'm seeing it fail in both an unrelated PR:
#29728
https://github.com/microsoft/onnxruntime/actions/runs/29509983398/job/87780661649?pr=29728
and in commits to main:
https://github.com/microsoft/onnxruntime/actions/runs/29546572913/job/87780090142
https://github.com/microsoft/onnxruntime/actions/runs/29499730505/job/87625355397
This is assuming the chain of causation:
windows_qnn_x64.ymlpipeline finds JDK 8 already on the runner (previous runner pool had JDK 11)This new workflow action hopefully installs a compatible JDK & all will be well.
#29753