Skip to content

Fix wrong ORT version in Windows DLL VersionInfo for pipeline builds #29545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skottmckay merged 2 commits into from
Jul 7, 2026
Merged

Fix wrong ORT version in Windows DLL VersionInfo for pipeline builds #29545

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e9f3c8
Fix wrong ORT version in Windows DLL VersionInfo for pipeline builds
Sammy-Dabbas Jul 5, 2026
357b3ea
Correct error message to reference VERSION_NUMBER
Sammy-Dabbas Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions tools/ci_build/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,39 +1069,39 @@ def generate_build_tree(
cmake_args += cmake_extra_args

# ADO pipelines will store the pipeline build number
# (e.g. 191101-2300.1.master) and source version in environment
# (e.g. 20260615.4) and source version in environment
# variables. If present, use these values to define the
# WinML/ORT DLL versions.
build_number = os.getenv("Build_BuildNumber") # noqa: SIM112
source_version = os.getenv("Build_SourceVersion") # noqa: SIM112
if build_number and source_version:
build_matches = re.fullmatch(r"(\d\d)(\d\d)(\d\d)(\d\d)\.(\d+)", build_number)
if build_matches:
YY = build_matches.group(2) # noqa: N806
MM = build_matches.group(3) # noqa: N806
DD = build_matches.group(4) # noqa: N806

# Get ORT major and minor number
# Get ORT major, minor, and patch number
with open(os.path.join(source_dir, "VERSION_NUMBER")) as f:
first_line = f.readline()
ort_version_matches = re.match(r"(\d+).(\d+)", first_line)
ort_version_matches = re.match(r"(\d+)\.(\d+)\.(\d+)", first_line)
if not ort_version_matches:
raise BuildError("Couldn't read version from VERSION_FILE")
ort_major = ort_version_matches.group(1)
Comment thread
tianleiwu marked this conversation as resolved.
ort_minor = ort_version_matches.group(2)
# Example (BuildNumber: 191101-2300.1.master,
# SourceVersion: 0bce7ae6755c792eda558e5d27ded701707dc404)
ort_patch = ort_version_matches.group(3)
# Example (VERSION_NUMBER: 1.27.0, BuildNumber: 20260615.4,
# SourceVersion: 8f0278c77bf44b0cc83c098c6c722b92a36ac4b5)
# MajorPart = 1
# MinorPart = 0
# BuildPart = 1911
# PrivatePart = 123
# String = 191101-2300.1.master.0bce7ae
# MinorPart = 27
# BuildPart = 0
# PrivatePart = 615
# String = 1.27.0.20260615.4.8f0278c
cmake_args += [
f"-DVERSION_MAJOR_PART={ort_major}",
f"-DVERSION_MINOR_PART={ort_minor}",
f"-DVERSION_BUILD_PART={YY}",
f"-DVERSION_BUILD_PART={ort_patch}",
f"-DVERSION_PRIVATE_PART={MM}{DD}",
f"-DVERSION_STRING={ort_major}.{ort_minor}.{build_number}.{source_version[0:7]}",
f"-DVERSION_STRING={ort_major}.{ort_minor}.{ort_patch}.{build_number}.{source_version[0:7]}",
]

for config in configs:
Expand Down