Skip to content

Fix incorrect string tensor creation in test #29219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuslepukhin merged 2 commits into from
Jun 23, 2026
Merged

Fix incorrect string tensor creation in test #29219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fb0bab
Fix incorrect string tensor creation in CreateGetVectorOfMapsStringFl…
Jun 22, 2026
b1347c4
Merge branch 'main' into yuslepukhin/gh_issue_13246_string_tensor
Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions onnxruntime/test/shared_lib/test_nontensor_types.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

#include <array>
#include <functional>
#include <iostream>
#include <set>
Expand Down Expand Up @@ -102,13 +103,13 @@ TEST(CApiTest, CreateGetVectorOfMapsStringFloat) { // support zipmap output typ
constexpr int64_t NUM_KV_PAIRS = 4;
std::vector<Ort::Value> in;
const char* keys_arr[NUM_KV_PAIRS] = {"abc", "def", "ghi", "jkl"};
std::vector<std::string> keys{keys_arr, keys_arr + NUM_KV_PAIRS};
std::vector<int64_t> dims = {NUM_KV_PAIRS};
std::vector<float> values{3.0f, 1.0f, 2.f, 0.f};
std::array<int64_t, 1> dims = {NUM_KV_PAIRS};
std::array<float, NUM_KV_PAIRS> values{3.0f, 1.0f, 2.f, 0.f};
for (size_t i = 0; i < N; ++i) {
// create key tensor
Ort::Value keys_tensor = Ort::Value::CreateTensor(info, keys.data(), keys.size() * sizeof(std::string),
dims.data(), dims.size(), ONNX_TENSOR_ELEMENT_DATA_TYPE_STRING);
Ort::Value keys_tensor = Ort::Value::CreateTensor(Ort::AllocatorWithDefaultOptions(), dims.data(), dims.size(),
ONNX_TENSOR_ELEMENT_DATA_TYPE_STRING);
keys_tensor.FillStringTensor(keys_arr, NUM_KV_PAIRS);
// create value tensor
Ort::Value values_tensor = Ort::Value::CreateTensor(info, values.data(), values.size() * sizeof(float),
dims.data(), dims.size(), ONNX_TENSOR_ELEMENT_DATA_TYPE_FLOAT);
Expand Down Expand Up @@ -147,7 +148,7 @@ TEST(CApiTest, CreateGetVectorOfMapsStringFloat) { // support zipmap output typ
std::string stemp(s + start, count);
keys_ret.insert(stemp);
}
ASSERT_EQ(keys_ret, std::set<std::string>(std::begin(keys), std::end(keys)));
ASSERT_EQ(keys_ret, std::set<std::string>(std::begin(keys_arr), std::end(keys_arr)));

// second fetch the values
Ort::Value values_ort = map_out.GetValue(1, default_allocator.get());
Expand Down
Loading