Fix oob dereference - #29012
Merged
Merged
Conversation
apsonawane
enabled auto-merge (squash)
June 11, 2026 19:32
kunal-vaishnavi
approved these changes
Jun 11, 2026
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request strengthens shape inference validation for several custom BERT-related ONNX operators by adding explicit rank checks for input tensors. These changes ensure that input tensors meet minimum rank requirements, improving error messaging and preventing incorrect shape propagation.
Enhanced shape validation for custom ONNX operators:
RelativePositionBias and GatedRelativePositionBias:
bias_table(forRelativePositionBias) andtoken_offset(forGatedRelativePositionBias) inputs have rank ≥ 2, with clear error messages if not. [1] [2]CausalConvWithState:
inputandweighttensors have rank ≥ 2, failing shape inference with descriptive errors if violated.LinearAttention:
queryandvaluetensors have rank ≥ 3 for both output and state shape inference, with early returns or errors if requirements are not met. [1] [2]SkipLayerNormalization:
inputtensor has rank ≥ 1, improving error reporting for invalid input shapes.