Skip to content

Log EP version on inference failure and in EpDeviceUsage event, Log ORT version - #28794

Merged
dabhattimsft merged 6 commits into
mainfrom
user/dabhatti/AddOrtEpVer
Jun 11, 2026
Merged

Log EP version on inference failure and in EpDeviceUsage event, Log ORT version#28794
dabhattimsft merged 6 commits into
mainfrom
user/dabhatti/AddOrtEpVer

Conversation

@dabhattimsft

Copy link
Copy Markdown
Contributor

Description

Adds new telemetry event for inference failure which logs ep versions and types along with runtime error.
Adds logging of ORT version in other telemetry events.
Adds logging of ep versions in SessionCreation telemetry

Motivation and Context

To better diagnose failures in inference

Darshak Bhatti added 3 commits May 22, 2026 15:11
@dabhattimsft
dabhattimsft requested a review from angelser June 4, 2026 20:35

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

Comment thread onnxruntime/core/session/inference_session.cc
angelser
angelser previously approved these changes Jun 4, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

Comment thread onnxruntime/core/session/inference_session.cc Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances ONNX Runtime’s Windows ETW telemetry to aid diagnosing inference failures by emitting EP version information, adding EP version details to EP/device usage events, and expanding multiple telemetry events to include the ORT runtime version.

Changes:

  • Add EP version collection in InferenceSession telemetry state and include it in SessionCreation and EpDeviceUsage telemetry.
  • Add a new LogRuntimeInferenceError telemetry event emitted on failed Run() calls, enriched with EP version/device type context.
  • Extend Windows telemetry schemas/events to log runtimeVersion (ORT version) and bump schema versions where payloads changed.
Show a summary per file
File Description
onnxruntime/core/session/inference_session.h Adds EP version fields to session telemetry state.
onnxruntime/core/session/inference_session.cc Populates EP versions, logs them in SessionCreation/EpDeviceUsage, and emits RuntimeInferenceError on Run failures.
onnxruntime/core/platform/windows/telemetry.h Extends WindowsTelemetry interface for EP versions + new inference error event.
onnxruntime/core/platform/windows/telemetry.cc Implements new/updated ETW events, adds runtimeVersion, and bumps schema versions.
onnxruntime/core/platform/telemetry.h Extends the Telemetry base interface for EP versions + new inference error event.
onnxruntime/core/platform/telemetry.cc Adds stub implementations/unused-parameter handling for the new Telemetry APIs.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 6/6 changed files
  • Comments generated: 2

Comment thread onnxruntime/core/platform/windows/telemetry.cc
Comment thread onnxruntime/core/session/inference_session.cc
Comment thread onnxruntime/core/session/inference_session.h
Comment thread onnxruntime/core/platform/windows/telemetry.cc
Comment thread onnxruntime/core/platform/windows/telemetry.cc
@dabhattimsft dabhattimsft self-assigned this Jun 10, 2026
@dabhattimsft
dabhattimsft merged commit 6584194 into main Jun 11, 2026
86 checks passed
@dabhattimsft
dabhattimsft deleted the user/dabhatti/AddOrtEpVer branch June 11, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants