-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[WebGPU] Fuse Q/K RMSNorm into GroupQueryAttention for Qwen3-style models #28484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
d190ac1
[WebGPU] Fuse Q/K RMSNorm into GroupQueryAttention decode
hariharans29 b9585c4
[WebGPU] Extract RunLayerNormProgram helper
hariharans29 6863729
[WebGPU] Tighten GroupQueryAttentionPreNormFusion preconditions
hariharans29 926437e
[GQA] Reject q_norm_weight / k_norm_weight inputs on CPU/CUDA/JSEP
hariharans29 98f4097
Merge remote-tracking branch 'origin' into hari/webgpu_perf_2
hariharans29 030d56c
[Test] Use custom checker for SkipsAlreadyFusedNode
hariharans29 86d61e5
[Test] Add <cmath> include for std::abs
hariharans29 c6965da
[Test] Fix stale comment on BuildQwenQkPostNormPattern
hariharans29 b4bd290
[Optimizer] Update GroupQueryAttentionPreNormFusion class doc to refl…
hariharans29 c263d6c
[Optimizer] Drop unused k{Q,K}NormWeightInputName constants
hariharans29 40986df
[WebGPU] Refresh stale q/k_norm_weight comment in GQA
hariharans29 6cbce92
[WebGPU] Clarify qk_norm_epsilon_ comment covers prefill fallback too
hariharans29 0fafb16
[Schema] Clarify q_norm_weight is honored by native WebGPU only
hariharans29 414684c
[Optimizer] Fix MatchPreNormReshapeChain doc comment (reshape order)
hariharans29 f247ae0
[Test] Fix uniform_int_distribution assertion in GQA pre-norm fusion …
hariharans29 21e09aa
Address Copilot review comments on PR #28484
hariharans29 1ee43af
Update docs
hariharans29 60debba
Merge branch 'main' into hari/webgpu_perf_2
hariharans29 c69d3f4
Merge remote-tracking branch 'origin/main' into hari/webgpu_perf_2
hariharans29 e5e45a3
Merge remote-tracking branch 'origin/main' into HEAD
hariharans29 6a3ed21
Merge main and resolve conflicts
hariharans29 0fe266e
Left one out
hariharans29 2e0ef86
Copilot comments
hariharans29 69312a3
Update doc
hariharans29 6a100f8
Add more tests
hariharans29 bf6e186
Fix
hariharans29 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.