Skip to content

[WebNN] Rename roundingType to outputShapeRounding for pool2d ops #28172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guschmue merged 2 commits into from
Apr 29, 2026
Merged

[WebNN] Rename roundingType to outputShapeRounding for pool2d ops #28172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
356b7cc
[WebNN] Rename roundingType to outputShapeRounding for pool2d ops
Honry Apr 22, 2026
fda131e
Update onnxruntime/core/providers/webnn/builders/impl/pool_op_builder.cc
Honry Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions onnxruntime/core/providers/webnn/builders/impl/pool_op_builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,10 @@ Status PoolOpBuilder::AddToModelBuilderImpl(ModelBuilder& model_builder,
options.set("padding", emscripten::val::array(padding));

const auto ceil_mode = helper.Get("ceil_mode", 0);
options.set("roundingType", ceil_mode == 0 ? emscripten::val("floor")
: emscripten::val("ceil"));
emscripten::val output_shape_rounding = ceil_mode == 0 ? emscripten::val("floor") : emscripten::val("ceil");
// WebNN renamed roundingType to outputShapeRounding, but set older name too for compatibility.
options.set("roundingType", output_shape_rounding);
options.set("outputShapeRounding", output_shape_rounding);

// WebNN doesn't support AveragePool with count_include_pad == 1, emulate it by pad + averagePool2d.
if (op_type == "AveragePool" && helper.Get("count_include_pad", 0) == 1) {
Expand Down
Loading