Skip to content

[DML EP] Disable 4-D MVN tests for DirectML #27930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tianleiwu merged 2 commits into from
Apr 2, 2026
Merged

[DML EP] Disable 4-D MVN tests for DirectML #27930

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c94ffff
Disable 4-D MVN tests for DirectML
hariharans29 Apr 1, 2026
6844c45
Address copilot comments
hariharans29 Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions onnxruntime/test/contrib_ops/tensor_op_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,10 @@ void MeanVarianceNormalizationAcrossChannels(bool across_channels, bool normaliz
test.AddAttribute("normalize_variance", normalize_variance ? one : zero);
test.AddInput<float>("input", {N, C, H, W}, X);
test.AddOutput<float>("output", {N, C, H, W}, result);
test.Run(OpTester::ExpectResult::kExpectSuccess, "", {kOpenVINOExecutionProvider, kTensorrtExecutionProvider}); // OpenVINO doesn't support MVN operator below opset 9. TensorRT doesn't support opset 8 of MVN operator.
// DML currently has known failures in this 4D MVN coverage.
Comment thread
hariharans29 marked this conversation as resolved.
// OpenVINO does not support MVN below opset 9. TensorRT does not support MVN opset 8.
test.Run(OpTester::ExpectResult::kExpectSuccess, "",
{kDmlExecutionProvider, kOpenVINOExecutionProvider, kTensorrtExecutionProvider});
}

void MeanVarianceNormalizationPerChannel(bool across_channels, bool normalize_variance) {
Expand Down Expand Up @@ -188,7 +191,10 @@ void MeanVarianceNormalizationPerChannel(bool across_channels, bool normalize_va
test.AddAttribute("normalize_variance", normalize_variance ? one : zero);
test.AddInput<float>("input", {N, C, H, W}, X);
test.AddOutput<float>("output", {N, C, H, W}, result);
test.Run(OpTester::ExpectResult::kExpectSuccess, "", {kOpenVINOExecutionProvider, kTensorrtExecutionProvider}); // OpenVINO doesn't support MVN operator below opset 9. TensorRT doesn't support opset 8 of MVN operator.
// DML currently has known failures in this 4D MVN coverage.
Comment thread
hariharans29 marked this conversation as resolved.
Outdated
// OpenVINO does not support MVN below opset 9. TensorRT does not support MVN opset 8.
test.Run(OpTester::ExpectResult::kExpectSuccess, "",
{kDmlExecutionProvider, kOpenVINOExecutionProvider, kTensorrtExecutionProvider});
}

TEST(MVNContribOpTest, MeanVarianceNormalizationCPUTest_Version1_TO_8) {
Expand Down
13 changes: 11 additions & 2 deletions onnxruntime/test/providers/cpu/tensor/mean_variance_normalization_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ TEST(MeanVarianceNormalizationTest, DefaultAxes) {
OpTester test("MeanVarianceNormalization", 9);
test.AddInput<float>("input", {N, C, H, W}, X);
test.AddOutput<float>("output", {N, C, H, W}, result);
test.Run();
// DML currently has known failures in this 4D default-axes MVN coverage. Keep coverage on
// CPU/other EPs while the DML-specific issue is investigated.
test.Run(OpTester::ExpectResult::kExpectSuccess, "", {kDmlExecutionProvider});
Comment thread
hariharans29 marked this conversation as resolved.
Outdated
}

static void TestMeanVarianceNormalizationOverAllAxes(const std::vector<int64_t>& shape) {
Expand All @@ -90,7 +92,12 @@ static void TestMeanVarianceNormalizationOverAllAxes(const std::vector<int64_t>&
test.AddInput<float>("input", shape, X);
test.AddOutput<float>("output", shape, Y);

test.Run();
if (shape.size() == 4) {
// Restrict the DML exclusion to the known failing 4D all-axes coverage.
Comment thread
hariharans29 marked this conversation as resolved.
test.Run(OpTester::ExpectResult::kExpectSuccess, "", {kDmlExecutionProvider});
} else {
test.Run();
}
}

TEST(MeanVarianceNormalizationTest, AllAxes) {
Expand Down Expand Up @@ -157,6 +164,8 @@ TEST(MeanVarianceNormalizationTest, AxesSubsets5D) {
test.AddOutput<float>("output", shape, Y.data(), Y.size());

if (DefaultDmlExecutionProvider().get() != nullptr) {
// 5D subset-axis coverage stays enabled for DML. Use a small tolerance to account for
// expected numeric drift without masking the separate 4D DML-specific failures.
test.SetOutputTolerance(0.001f);
}

Expand Down
Loading