Fix new-delete mismatch in DML EP's QuantizeLinear operator by adrastogi · Pull Request #27823 · microsoft/onnxruntime

adrastogi · 2026-03-24T04:06:10Z

Description

DmlOperatorQuantization21 was missing the tensor reshaping logic that the older DmlOperatorElementwiseQLinear already had.

Scalar scale tensors get padded to 4D, but a 5D input stays 5D. DML rejects the dimension mismatch with E_INVALIDARG, and the resulting exception unwind triggers a sized-delete bug in WRL's MakeAllocator which address sanitizer detects. The fix is to port the same logic from the DmlOperatorElementwiseQLinear into this path, so that the dimensions match.

Motivation and Context

This is required to ensure the DML EP correctly handles this scenario.

fdwr · 2026-03-24T06:52:10Z

exception unwind triggers a sized-delete bug in WRL's MakeAllocator

Is this fix hiding any remaining allocation issue which a different E_INVALIDARG might cause?

fdwr

Glad you found it. 🔍 Approved with some recommendations.

onnxruntime/core/providers/dml/DmlExecutionProvider/src/Operators/DmlOperatorElementWise.cpp

fdwr

✌️

fdwr

Change looks okay to me (assuming the initial ref count is 1 rather than 0), but I wonder if this location is sufficient (other places use MakeOrThrow), and whether this is actually an issue because the heap block size is stored in the heap itself, meaning a sized delete mismatch seems bad in theory but not in practice (operator delete just calls free which reads the heap block header to read the block size - the same value that _msize function returns).

onnxruntime/core/providers/dml/OperatorAuthorHelper/MLOperatorAuthorHelper.h

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fdwr

👍

fdwr · 2026-03-28T05:35:09Z

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline,Windows GPU WebGPU CI Pipeline,Windows OpenVINO CI Pipeline

fdwr · 2026-03-28T05:35:12Z

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,MacOS CI Pipeline,Windows CPU CI Pipeline

fdwr · 2026-03-28T05:35:15Z

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline

fdwr · 2026-03-28T05:35:18Z

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

azure-pipelines · 2026-03-28T05:35:18Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2026-03-28T05:35:19Z

No pipelines are associated with this pull request.

fdwr · 2026-03-28T05:35:20Z

/azp run Test Linux CUDA x64 Release,Test Linux TensorRT x64 Release,web_Debug / build_onnxruntime_web,web_Release / build_onnxruntime_web

azure-pipelines · 2026-03-28T05:35:21Z

No pipelines are associated with this pull request.

fdwr · 2026-03-28T05:35:22Z

/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows GPU Doc Gen CI Pipeline,Windows ARM64 QNN CI Pipeline

azure-pipelines · 2026-03-28T05:35:25Z

No pipelines are associated with this pull request.

azure-pipelines · 2026-03-28T05:35:27Z

No pipelines are associated with this pull request.

azure-pipelines · 2026-03-28T05:35:37Z

Azure Pipelines successfully started running 4 pipeline(s).

onnxruntime/test/providers/dml_safe_make_or_throw_test.cc

github-actions

You can commit the suggested changes from lintrunner.

onnxruntime/test/providers/dml_safe_make_or_throw_test.cc

fdwr

👍

### Description  DmlOperatorQuantization21 was missing the tensor reshaping logic that the older DmlOperatorElementwiseQLinear already had. Scalar scale tensors get padded to 4D, but a 5D input stays 5D. DML rejects the dimension mismatch with E_INVALIDARG, and the resulting exception unwind triggers a sized-delete bug in WRL's MakeAllocator which address sanitizer detects. The fix is to port the same logic from the DmlOperatorElementwiseQLinear into this path, so that the dimensions match. ### Motivation and Context  This is required to ensure the DML EP correctly handles this scenario. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This cherry-picks the following commits for the release: - #26434 [VitisAI]add tensor type bool - #26452 [VitisAI EP] Fix error in graph resolving - #26487 [VitisAI] Enable ort::logger usage in compile_onnx_model_vitisai_ep_v4 - #26519 [VitisAI] Remove unused function body handling in graph fusion - #26627 [VitisAI] Add External EP Loader - #26699 [VitisAI] Add support compiled model compatibility information retrieval and validation - #27295 Remove s_kernel_registry_vitisaiep.reset() in deinitialize_vitisai_ep() - #27356 Add/Update telemetry events - #27626 Add PE version info to onnxruntime_providers_vitisai.dll - #27693 Fix integer division by zero crash in CPU EP Div operator - #27815 Fix overflow in DmlGraphFusionHelper::ProcessInputData - #27823 Fix new-delete mismatch in DML EP's QuantizeLinear operator --------- Co-authored-by: Yueqing Zhang <yuz75@Pitt.edu> Co-authored-by: Yueqing Zhang <yueqingz@amd.com> Co-authored-by: zpye <yezupei92@foxmail.com> Co-authored-by: Chunye Wang@AMD <chunywan@amd.com> Co-authored-by: mingyue <131847423+mingyueliuh@users.noreply.github.com> Co-authored-by: zz002 <zhenzew@amd.com> Co-authored-by: Darshak Bhatti <47045043+dabhattimsft@users.noreply.github.com> Co-authored-by: Darshak Bhatti <dabhatti@micorsoft.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Xiaoxi Han <xiha@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com> Co-authored-by: skottmckay <979079+skottmckay@users.noreply.github.com> Co-authored-by: Tianlei Wu <tlwu@microsoft.com>

Candidate fix

a76cd7e

adrastogi requested review from RafaelCintron and fdwr March 24, 2026 04:07

fdwr previously approved these changes Mar 24, 2026

View reviewed changes

onnxruntime/core/providers/dml/DmlExecutionProvider/src/Operators/DmlOperatorElementWise.cpp Outdated Show resolved Hide resolved

onnxruntime/core/providers/dml/DmlExecutionProvider/src/Operators/DmlOperatorElementWise.cpp Outdated Show resolved Hide resolved

PR feedback (consolidate duplicated implementation)

f84222e

adrastogi dismissed fdwr’s stale review via f84222e March 24, 2026 18:02

fdwr previously approved these changes Mar 24, 2026

View reviewed changes

PR feedback (harden operator classes for this problem)

bc5a2e0

adrastogi dismissed fdwr’s stale review via bc5a2e0 March 24, 2026 23:50

fdwr previously approved these changes Mar 26, 2026

View reviewed changes

onnxruntime/core/providers/dml/OperatorAuthorHelper/MLOperatorAuthorHelper.h Outdated Show resolved Hide resolved

onnxruntime/core/providers/dml/OperatorAuthorHelper/MLOperatorAuthorHelper.h Show resolved Hide resolved

adrastogi and others added 2 commits March 27, 2026 08:46

Candidate refactor

f56f256

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add SafeMakeOrThrow unit tests for ref count and leak verification

1a71145

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

adrastogi dismissed fdwr’s stale review via 1a71145 March 27, 2026 16:37

fdwr previously approved these changes Mar 27, 2026

View reviewed changes

adrastogi mentioned this pull request Mar 28, 2026

[Build] CI pipelines across multiple PRs are not being picked up by any runners (blocks check-in) #27890

Open

github-advanced-security bot found potential problems Mar 29, 2026

View reviewed changes

onnxruntime/test/providers/dml_safe_make_or_throw_test.cc Fixed Show fixed Hide fixed

github-actions bot reviewed Mar 29, 2026

View reviewed changes

PR feedback (lintrunner -a fixes)

c7e914d

adrastogi dismissed fdwr’s stale review via c7e914d March 29, 2026 04:10

fdwr approved these changes Mar 30, 2026

View reviewed changes

adrastogi merged commit c884195 into main Mar 30, 2026
103 of 105 checks passed

adrastogi deleted the adrastogi/dml-new-delete branch March 30, 2026 00:29

adrastogi mentioned this pull request Mar 30, 2026

ORT 1.23.5 Cherry Picks #27716

Merged

Conversation

adrastogi commented Mar 24, 2026

Description

Motivation and Context

Uh oh!

fdwr commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fdwr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fdwr left a comment

Choose a reason for hiding this comment

Uh oh!

fdwr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fdwr left a comment

Choose a reason for hiding this comment

Uh oh!

fdwr commented Mar 28, 2026

Uh oh!

fdwr commented Mar 28, 2026

Uh oh!

fdwr commented Mar 28, 2026

Uh oh!

fdwr commented Mar 28, 2026

Uh oh!

azure-pipelines bot commented Mar 28, 2026

Uh oh!

azure-pipelines bot commented Mar 28, 2026

Uh oh!

fdwr commented Mar 28, 2026

Uh oh!

azure-pipelines bot commented Mar 28, 2026

Uh oh!

fdwr commented Mar 28, 2026

Uh oh!

azure-pipelines bot commented Mar 28, 2026

Uh oh!

azure-pipelines bot commented Mar 28, 2026

Uh oh!

azure-pipelines bot commented Mar 28, 2026

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fdwr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fdwr commented Mar 24, 2026 •

edited

Loading

fdwr left a comment •

edited

Loading