Skip to content

[MLAS] Enable BF16 KAI SBGemm on NCHWc ARM builds #27703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hariharans29 merged 2 commits into from
Mar 18, 2026
Merged

[MLAS] Enable BF16 KAI SBGemm on NCHWc ARM builds #27703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e4ec6c
Enable BF16 KAI SBGemm on NCHWc ARM builds
hariharans29 Mar 17, 2026
0539673
Potential fix for pull request finding
hariharans29 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion onnxruntime/core/mlas/lib/sbconv_kernel_neon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,12 @@ MlasConvPointwiseBf16KernelNeon(
const bool ReluActivation = (KernelFlags & MLAS_CONV_KERNEL_FLAG_RELU_ACTIVATION) != 0;

MLAS_BACKEND_KERNEL_SELECTOR_CONFIG mlas_backend_kernel_selector_config;
mlas_backend_kernel_selector_config.use_kleidiai = ((KernelFlags & MLAS_CONV_KERNEL_MLAS_ARM_USE_KLEIDIAI) != 0);

// TODO(hasesh): With the ARM KleidiAI team, study the impact of using the KleidiAI SBGEMM kernel for this convolution kernel
// and enable it if things look okay.
// Even if re-enabled, honor user override to disable KleidiAI usage if specified.
// That is, mlas_backend_kernel_selector_config.use_kleidiai = ((KernelFlags & MLAS_CONV_KERNEL_MLAS_ARM_USE_KLEIDIAI) != 0);
mlas_backend_kernel_selector_config.use_kleidiai = false;

const size_t StrideWidthElements = StrideWidth / sizeof(float);
const size_t InputStrideElements = InputStride / sizeof(float);
Expand Down
6 changes: 3 additions & 3 deletions onnxruntime/core/mlas/lib/sbgemm.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ MlasSBGemmPackBSize(
//
// Compute the number of bytes required to hold the packed buffer.
//
#if defined(USE_KLEIDIAI) && !defined(MLAS_USE_ARM_NEON_NCHWC)
#if defined(USE_KLEIDIAI)
if ((!BackendKernelSelectorConfig || BackendKernelSelectorConfig->use_kleidiai) &&
GetMlasPlatform().MlasSBGemmPackBSizeOverride != nullptr &&
TransA == CBLAS_TRANSPOSE::CblasNoTrans &&
Expand Down Expand Up @@ -359,7 +359,7 @@ MlasSBGemmConvertPackB(
const MLAS_BACKEND_KERNEL_SELECTOR_CONFIG* BackendKernelSelectorConfig
)
{
#if defined(USE_KLEIDIAI) && !defined(MLAS_USE_ARM_NEON_NCHWC)
#if defined(USE_KLEIDIAI)
if ((!BackendKernelSelectorConfig || BackendKernelSelectorConfig->use_kleidiai) &&
GetMlasPlatform().MlasSBGemmPackBOverride != nullptr &&
TransA == CBLAS_TRANSPOSE::CblasNoTrans &&
Expand Down Expand Up @@ -393,7 +393,7 @@ MlasSBGemmBatch(
const MLAS_BACKEND_KERNEL_SELECTOR_CONFIG* BackendKernelSelectorConfig
)
{
#if defined(USE_KLEIDIAI) && !defined(MLAS_USE_ARM_NEON_NCHWC)
#if defined(USE_KLEIDIAI)
if ((!BackendKernelSelectorConfig || BackendKernelSelectorConfig->use_kleidiai) &&
GetMlasPlatform().MlasSBGemmBatchOverride != nullptr &&
TransA == CBLAS_TRANSPOSE::CblasNoTrans &&
Expand Down
Loading