[CUDA] Update Pad kernel to support versioning and add tests for Opset 19#27701
[CUDA] Update Pad kernel to support versioning and add tests for Opset 19#27701lukas-folle-snkeos wants to merge 1 commit intomicrosoft:mainfrom
Conversation
SummaryThe direction is good: moving CUDA Pad away from a single opset-18 registration and adding a CUDA-focused regression test is the right shape of change. However, the current registration range is not safe yet because it makes CUDA eligible for opset-19+ Review1. CUDA Pad Versioning (
|
| # | Severity | Component | Issue |
|---|---|---|---|
| 1 | High | CUDA Pad versioning | Registers opset-19+ Pad on CUDA even though wrap is part of those schemas and is not implemented in the CUDA kernels. |
| 2 | Suggestion | Schema coverage and tests | Registration only goes through opset 23, leaving opset 24/25 Pad models without CUDA coverage. |
Verdict
REQUEST CHANGES — the current versioned registration would expose unsupported wrap Pad nodes to CUDA placement, so the PR is not safe to merge as-is.
|
@lukas-folle-snkeos, I added a new PR #27708 to extend Pad up to opset 25. Your commit and contribution is kept. Thanks. |
|
@tianleiwu thanks for getting to this so quickly. I am closing this PR in favor of your #27708 |
Description
This pull request updates the CUDA kernel registration for the
Padoperator in ONNX Runtime to use versioned kernel registration for opsets 18 through 23, and adds test coverage for CUDA-specific behavior.Motivation and Context
Fixes #26393