Skip to content

[Plugin EP] Check for nullptr before dereferencing#27644

Merged
tianleiwu merged 2 commits intomicrosoft:mainfrom
ROCm:nullptr_deref_on_output
Mar 16, 2026
Merged

[Plugin EP] Check for nullptr before dereferencing#27644
tianleiwu merged 2 commits intomicrosoft:mainfrom
ROCm:nullptr_deref_on_output

Conversation

@apwojcik
Copy link
Copy Markdown
Contributor

It seems some outputs on the spanned list may be nullptrs. By checking for nullptr and skipping them if found, it does not seem to disturb proper execution on models.

That check was not required for legacy EP using the Host API.

@adrianlizarraga
Copy link
Copy Markdown
Contributor

Hi @apwojcik, can you please sync with the latest main branch to get CI checks to pass? Thanks.

@tianleiwu
Copy link
Copy Markdown
Contributor

/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 4 pipeline(s).

@tianleiwu tianleiwu enabled auto-merge (squash) March 15, 2026 00:02
@tianleiwu tianleiwu merged commit 0f66526 into microsoft:main Mar 16, 2026
90 of 91 checks passed
tianleiwu pushed a commit that referenced this pull request Mar 16, 2026
It seems some outputs on the spanned list may be nullptrs. By checking
for nullptr and skipping them if found, it does not seem to disturb
proper execution on models.

That check was not required for legacy EP using the Host API.
tianleiwu added a commit that referenced this pull request Mar 16, 2026
This cherry-picks the following commits for the release:

| Commit ID | PR Number | Commit Title |
|-----------|-----------|-------------|
| eb23be8 | #27354 | Update python_requires |
| d626b56 | #27479 | [QNN EP] Enable offline x64 compilation with
memhandle IO type |
| 60ce0e6 | #27607 | Use `_tpause` instead of `__builtin_ia32_tpause`
|
| 69feb84 | #27591 | Add PCI bus fallback for Linux GPU device
discovery in containerized environments |
| de92668 | #27650 | Revert "[QNN EP] Fix error messages being logged
as VERBOSE instead o… |
| 0f66526 | #27644 | [Plugin EP] Check for nullptr before
dereferencing |
| 929f73e | #27666 | Plugin EP: Fix bug that incorrectly assigned
duplicate MetDef IDs to fused nodes in different GraphViews |

---------

Co-authored-by: XXXXRT666 <157766680+XXXXRT666@users.noreply.github.com>
Co-authored-by: derdeljan-msft <derdeljan@microsoft.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Shogo Yamazaki <f9ifphmiz7i8akhowc8l5t1x9qp0lfu4@mocknen.net>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: baijumeswani <12852605+baijumeswani@users.noreply.github.com>
Co-authored-by: edgchen1 <18449977+edgchen1@users.noreply.github.com>
Co-authored-by: Baiju Meswani <bmeswani@microsoft.com>
Co-authored-by: Artur Wojcik <artur.wojcik@amd.com>
Co-authored-by: Adrian Lizarraga <adlizarraga@microsoft.com>
qti-mattsinc added a commit to onnxruntime/onnxruntime-qnn that referenced this pull request Mar 18, 2026
* ORT 1.24.4 includes a fix for an access violation when
  the EP queries producer/consumer info on a missing
  optional input/output:
  microsoft/onnxruntime#27644.
* Bumping to 1.24.4 in anticipation of unit tests that
  will require that fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants