Skip to content

[React Native] Fix float16 tensor crash by mapping to Uint16Array #27549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tianleiwu merged 4 commits into from
Mar 20, 2026
Merged

[React Native] Fix float16 tensor crash by mapping to Uint16Array #27549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a96b45e
[React Native] Fix float16 tensor crash by mapping to Uint16Array
kevinlam92 Mar 4, 2026
768c80a
Add float16 e2e test to BasicTypesTest
kevinlam92 Mar 10, 2026
4ee137e
Add float16 model to iOS
kevinlam92 Mar 10, 2026
087c97c
Fix test model shape
kevinlam92 Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/react_native/cpp/TensorUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ static const std::unordered_map<ONNXTensorElementDataType, const char*>
{ONNX_TENSOR_ELEMENT_DATA_TYPE_INT8, "Int8Array"},
{ONNX_TENSOR_ELEMENT_DATA_TYPE_UINT16, "Uint16Array"},
{ONNX_TENSOR_ELEMENT_DATA_TYPE_INT16, "Int16Array"},
{ONNX_TENSOR_ELEMENT_DATA_TYPE_FLOAT16, "Float16Array"},
{ONNX_TENSOR_ELEMENT_DATA_TYPE_FLOAT16, "Uint16Array"},
Comment thread
tianleiwu marked this conversation as resolved.
{ONNX_TENSOR_ELEMENT_DATA_TYPE_STRING, "Array"},
{ONNX_TENSOR_ELEMENT_DATA_TYPE_BOOL, "Uint8Array"},
};
Expand Down
Binary file added js/react_native/e2e/android/app/src/main/assets/test_types_float16.ort
View file
Open in desktop
Binary file not shown.
4 changes: 4 additions & 0 deletions js/react_native/e2e/ios/OnnxruntimeModuleExample.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
3ADD0A3E2EBB64D200761D6F /* ../src/test_types_int32.ort in Resources */ = {isa = PBXBuildFile; fileRef = 3ADD0A392EBB64D200761D6F /* ../src/test_types_int32.ort */; };
3ADD0A3F2EBB64D200761D6F /* ../src/test_types_float.ort in Resources */ = {isa = PBXBuildFile; fileRef = 3ADD0A372EBB64D200761D6F /* ../src/test_types_float.ort */; };
3ADD0A402EBB64D200761D6F /* ../src/test_types_uint8.ort in Resources */ = {isa = PBXBuildFile; fileRef = 3ADD0A3B2EBB64D200761D6F /* ../src/test_types_uint8.ort */; };
3ADD0A462EBB64D200761D6F /* ../src/test_types_float16.ort in Resources */ = {isa = PBXBuildFile; fileRef = 3ADD0A452EBB64D200761D6F /* ../src/test_types_float16.ort */; };
3ADD0A422EBB677300761D6F /* test_types_double.onnx in Resources */ = {isa = PBXBuildFile; fileRef = 3ADD0A412EBB677300761D6F /* test_types_double.onnx */; };
3ADD0A442EBB679A00761D6F /* test_types_bool.onnx in Resources */ = {isa = PBXBuildFile; fileRef = 3ADD0A432EBB679A00761D6F /* test_types_bool.onnx */; };
81AB9BB82411601600AC10FF /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 81AB9BB72411601600AC10FF /* LaunchScreen.storyboard */; };
Expand Down Expand Up @@ -62,6 +63,7 @@
3ADD0A392EBB64D200761D6F /* ../src/test_types_int32.ort */ = {isa = PBXFileReference; lastKnownFileType = file; path = ../src/test_types_int32.ort; sourceTree = "<group>"; };
3ADD0A3A2EBB64D200761D6F /* ../src/test_types_int64.ort */ = {isa = PBXFileReference; lastKnownFileType = file; path = ../src/test_types_int64.ort; sourceTree = "<group>"; };
3ADD0A3B2EBB64D200761D6F /* ../src/test_types_uint8.ort */ = {isa = PBXFileReference; lastKnownFileType = file; path = ../src/test_types_uint8.ort; sourceTree = "<group>"; };
3ADD0A452EBB64D200761D6F /* ../src/test_types_float16.ort */ = {isa = PBXFileReference; lastKnownFileType = file; path = ../src/test_types_float16.ort; sourceTree = "<group>"; };
3ADD0A412EBB677300761D6F /* test_types_double.onnx */ = {isa = PBXFileReference; lastKnownFileType = file; path = ../src/test_types_double.onnx; sourceTree = "<group>"; };
3ADD0A432EBB679A00761D6F /* test_types_bool.onnx */ = {isa = PBXFileReference; lastKnownFileType = file; path = ../src/test_types_bool.onnx; sourceTree = "<group>"; };
81AB9BB72411601600AC10FF /* LaunchScreen.storyboard */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.storyboard; name = LaunchScreen.storyboard; path = OnnxruntimeModuleExample/LaunchScreen.storyboard; sourceTree = "<group>"; };
Expand Down Expand Up @@ -149,6 +151,7 @@
3ADD0A392EBB64D200761D6F /* ../src/test_types_int32.ort */,
3ADD0A3A2EBB64D200761D6F /* ../src/test_types_int64.ort */,
3ADD0A3B2EBB64D200761D6F /* ../src/test_types_uint8.ort */,
3ADD0A452EBB64D200761D6F /* ../src/test_types_float16.ort */,
DBA8BA86267293C4008CC55A /* mnist.ort */,
DBBF7413263B8CCB00487C77 /* 3.jpg */,
13B07FAE1A68108700A75B9A /* OnnxruntimeModuleExample */,
Expand Down Expand Up @@ -275,6 +278,7 @@
3ADD0A3E2EBB64D200761D6F /* ../src/test_types_int32.ort in Resources */,
3ADD0A3F2EBB64D200761D6F /* ../src/test_types_float.ort in Resources */,
3ADD0A402EBB64D200761D6F /* ../src/test_types_uint8.ort in Resources */,
3ADD0A462EBB64D200761D6F /* ../src/test_types_float16.ort in Resources */,
E329E1162D3728940016B599 /* PrivacyInfo.xcprivacy in Resources */,
13B07FBF1A68108700A75B9A /* Images.xcassets in Resources */,
);
Expand Down
13 changes: 13 additions & 0 deletions js/react_native/e2e/src/BasicTypesTest.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ const TEST_MODELS: TestModel[] = [
dataType: 'float32',
description: 'Test float32 data type',
},
{
name: 'Float16',
asset: 'test_types_float16.ort',
dataType: 'float16',
description: 'Test float16 data type',
},
{
name: 'Double',
asset: 'test_types_double.onnx',
Expand Down Expand Up @@ -211,6 +217,13 @@ export default class BasicTypesTest extends React.PureComponent<{}, State> {
}
return data;
}
case 'float16': {
const data = new Uint16Array(size);
for (let i = 0; i < size; i++) {
data[i] = i;
}
return data;
}
case 'float64': {
const data = new Float64Array(size);
for (let i = 0; i < size; i++) {
Expand Down
Binary file added js/react_native/e2e/src/test_types_float16.ort
View file
Open in desktop
Binary file not shown.
Loading