Skip to content

Remove CMake HAS_ARRAY_BOUNDS variable. #27519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edgchen1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove CMake HAS_ARRAY_BOUNDS variable. #27519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cmake/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,6 @@ else()
check_cxx_compiler_flag(-Wambiguous-reversed-operator HAS_AMBIGUOUS_REVERSED_OPERATOR)
# -Winterference-size was added in GCC 13
check_cxx_compiler_flag(-Winterference-size HAS_INTERFERENCE_SIZE)
check_cxx_compiler_flag(-Warray-bounds HAS_ARRAY_BOUNDS)
check_cxx_compiler_flag(-Wbitwise-instead-of-logical HAS_BITWISE_INSTEAD_OF_LOGICAL)
check_cxx_compiler_flag(-Wcast-function-type HAS_CAST_FUNCTION_TYPE)
check_cxx_compiler_flag(-Wcatch-value HAS_CATCH_VALUE)
Expand Down
1 change: 0 additions & 1 deletion cmake/onnxruntime_config.h.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

#pragma once

#cmakedefine HAS_ARRAY_BOUNDS
#cmakedefine HAS_BITWISE_INSTEAD_OF_LOGICAL
#cmakedefine HAS_CAST_FUNCTION_TYPE
#cmakedefine HAS_CATCH_VALUE
Expand Down
5 changes: 2 additions & 3 deletions include/onnxruntime/core/framework/int2.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include <type_traits>
#include "core/common/common.h"
#include <gsl/gsl>
#include "onnxruntime_config.h"

namespace onnxruntime {

Expand Down Expand Up @@ -140,12 +139,12 @@ struct Int2x4Base {
// Process complete groups of 4 elements

for (; dst_i < full_quads; dst_i++) {
#if defined(__GNUC__) && defined(HAS_ARRAY_BOUNDS)
#if defined(__GNUC__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Warray-bounds"
#endif
dst[dst_i] = Int2x4Base<Signed>(src[src_i], src[src_i + 1], src[src_i + 2], src[src_i + 3]);
#if defined(__GNUC__) && defined(HAS_ARRAY_BOUNDS)
#if defined(__GNUC__)
#pragma GCC diagnostic pop
#endif
src_i += 4;
Expand Down
Loading