Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds ONNX Softplus operator support to the WebGPU Execution Provider, enabling execution of models (e.g., onnx-community/Falcon-H1-Tiny-90M-Instruct-ONNX) that include Softplus nodes on WebGPU.
Changes:
- Register WebGPU Softplus kernels for ONNX opsets 1–21 and opset 22.
- Implement Softplus as a WebGPU unary elementwise shader using a numerically-stable formulation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
onnxruntime/core/providers/webgpu/webgpu_execution_provider.cc |
Registers Softplus kernels in the WebGPU kernel registry for opsets 1–21 and 22. |
onnxruntime/core/providers/webgpu/math/unary_elementwise_ops.cc |
Adds the Softplus WGSL expression and hooks it into the WebGPU unary elementwise kernel macros (versioned + opset 22). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xenova
reviewed
Feb 25, 2026
xenova
approved these changes
Feb 26, 2026
Contributor
There was a problem hiding this comment.
LGTM ✅
>>> import torch
>>> (torch.log(1 + torch.exp(torch.tensor(20.0, dtype=torch.float32))) - 20.0).item()
0.0
>>> (torch.log(1 + torch.exp(torch.tensor(11.0, dtype=torch.float16))) - 11.0).item()
0.0in pytorch, error is zero using these approximations in the relevant cases.
fs-eire
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needed by onnx-community/Falcon-H1-Tiny-90M-Instruct-ONNX