Add validity check on MaxUnpool indicies.#27432
Merged
skottmckay merged 3 commits intomainfrom Feb 25, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds input validation for MaxUnpool indices to prevent invalid memory writes. The operator now checks that each index is within the valid range [0, output_size) before using it to write to the output tensor, fixing a potential out-of-bounds write vulnerability.
Changes:
- Added bounds checking for indices in MaxUnpool operator to validate they are non-negative and within the output tensor size
- Added test case to verify the operator correctly rejects out-of-bounds indices with a clear error message
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| onnxruntime/core/providers/cpu/nn/Unpool.cc | Added validation to check indices are within bounds [0, output_size) before writing to output tensor, preventing invalid writes |
| onnxruntime/test/providers/cpu/nn/unpool_op_test.cc | Added test case MaxUnpoolInvalidIndices to verify proper error handling for out-of-bounds indices |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tianleiwu
approved these changes
Feb 24, 2026
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Check indices values are valid.
Motivation and Context
Fix invalid write.