Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the IsReleaseBuild parameter was not being correctly passed to the validate_package.py script in various Azure Pipeline stages for CUDA NuGet packaging. The parameter is required by the validation script to properly verify packages based on whether they are release builds or not.
Changes:
- Added
IsReleaseBuildparameter definitions tonuget-win-cuda-packaging-stage.ymlandnuget-linux-cuda-packaging-stage.ymltemplates with default value offalse - Updated
nuget-combine-cuda-stage.ymlto pass theIsReleaseBuildparameter to Linux and Windows CUDA packaging sub-stages - Added
IsReleaseBuildparameter to all threevalidate-package.ymltemplate calls innuget-cuda-packaging-stage.ymlfor validating the combined Gpu, Gpu.Windows, and Gpu.Linux packages
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/ci_build/github/azure-pipelines/stages/nuget-win-cuda-packaging-stage.yml | Added IsReleaseBuild parameter definition (lines 58-60) and passed it to validate-package.yml call for Windows GPU package validation (line 185) |
| tools/ci_build/github/azure-pipelines/stages/nuget-linux-cuda-packaging-stage.yml | Added IsReleaseBuild parameter definition (lines 9-11) and passed it to validate-package.yml call for Linux GPU package validation (line 208) |
| tools/ci_build/github/azure-pipelines/stages/nuget-cuda-packaging-stage.yml | Passed IsReleaseBuild to three validate-package.yml calls for combined Gpu package, Windows-specific package, and Linux-specific package (lines 189, 198, 207) |
| tools/ci_build/github/azure-pipelines/stages/nuget-combine-cuda-stage.yml | Passed IsReleaseBuild parameter through to both Linux and Windows CUDA packaging stages (lines 60, 75) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tools/ci_build/github/azure-pipelines/stages/nuget-cuda-packaging-stage.yml
Show resolved
Hide resolved
eserscor
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the is_release_build parameter was not being correctly passed to the validate_package.py script across various Azure Pipelines.
Changes
tools/ci_build/github/azure-pipelines/stages/nuget-linux-cuda-packaging-stage.yml
tools/ci_build/github/azure-pipelines/stages/nuget-win-cuda-packaging-stage.yml
Context
It is based on #27382.