-
Notifications
You must be signed in to change notification settings - Fork 4k
Add cherry_pick.py script for ORT release #27333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4639c59
Add cherry-pick script
tianleiwu dd0d487
lintrunner
tianleiwu 6a44998
address copilot feedback
tianleiwu 1e6bbf9
update compile contributors patterns
tianleiwu 1c40b36
output sh and markdown table
tianleiwu 90d5604
refactoring
tianleiwu ff6f523
format
tianleiwu 33687c5
status
tianleiwu 433e8e3
review feedback
tianleiwu d7e922b
address more feedback
tianleiwu 51e1db1
final feedback
tianleiwu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,179 @@ | ||
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
|
tianleiwu marked this conversation as resolved.
Fixed
|
||
| # Licensed under the MIT License. | ||
| # | ||
| # Usage: | ||
| # python create_cherry_pick.py --label "release:1.24.2" --output cherry_pick.cmd --branch "origin/rel-1.24.2" | ||
|
tianleiwu marked this conversation as resolved.
Outdated
|
||
| # | ||
| # Arguments: | ||
| # --label: Label to filter PRs (required) | ||
| # --output: Output cmd file path (required) | ||
| # --repo: Repository (default: microsoft/onnxruntime) | ||
| # --branch: Target branch to compare against for dependency checks (default: HEAD) | ||
| # | ||
| # This script fetches merged PRs with the specified label from the onnxruntime repository, | ||
| # sorts them by merge date, and generates: | ||
| # 1. A batch file (specified by --output) containing git cherry-pick commands. | ||
| # 2. A markdown file (cherry_pick_pr_description.md) summarizing the cherry-picked PRs for pull request description. | ||
| # | ||
| # It also checks for potential missing dependencies (conflicts) by verifying if files modified | ||
| # by the cherry-picked commits have any other modifications in the target branch history | ||
| # that are not included in the cherry-pick list. | ||
|
tianleiwu marked this conversation as resolved.
Outdated
|
||
| import argparse | ||
|
tianleiwu marked this conversation as resolved.
Fixed
|
||
| import json | ||
| import subprocess | ||
| import sys | ||
| from collections import defaultdict | ||
|
|
||
|
tianleiwu marked this conversation as resolved.
|
||
|
|
||
| def main(): | ||
| parser = argparse.ArgumentParser(description="Generate cherry-pick script from PRs with a specific label.") | ||
| parser.add_argument("--label", required=True, help="Label to filter PRs") | ||
| parser.add_argument("--output", required=True, help="Output cmd file path") | ||
| parser.add_argument("--repo", default="microsoft/onnxruntime", help="Repository (default: microsoft/onnxruntime)") | ||
| parser.add_argument( | ||
| "--branch", default="HEAD", help="Target branch to compare against for dependency checks (default: HEAD)" | ||
| ) | ||
| args = parser.parse_args() | ||
|
|
||
| # Fetch merged PRs with the specified label using gh CLI | ||
| print(f"Fetching merged PRs with label '{args.label}' from {args.repo}...") | ||
| cmd = [ | ||
| "gh", | ||
| "pr", | ||
| "list", | ||
| "--repo", | ||
| args.repo, | ||
| "--label", | ||
| args.label, | ||
| "--state", | ||
| "merged", | ||
| "--json", | ||
| "number,title,mergeCommit,mergedAt", | ||
| "-L", | ||
| "200", | ||
| ] | ||
|
tianleiwu marked this conversation as resolved.
|
||
|
|
||
| try: | ||
| result = subprocess.run(cmd, capture_output=True, text=True, check=True) | ||
| prs = json.loads(result.stdout) | ||
|
tianleiwu marked this conversation as resolved.
Outdated
|
||
| except subprocess.CalledProcessError as e: | ||
| print(f"Error running gh command: {e}", file=sys.stderr) | ||
| print(e.stderr, file=sys.stderr) | ||
| sys.exit(1) | ||
| except json.JSONDecodeError as e: | ||
| print(f"Error parsing gh output: {e}", file=sys.stderr) | ||
| print(f"Output was: {result.stdout}", file=sys.stderr) | ||
| sys.exit(1) | ||
|
|
||
| if not prs: | ||
| print(f"No PRs found with label '{args.label}'.") | ||
| return | ||
|
|
||
| # Sort by mergedAt (ISO 8601 strings sort correctly in chronological order) | ||
| prs.sort(key=lambda x: x["mergedAt"]) | ||
|
|
||
| # Write to output cmd file | ||
| commit_count = 0 | ||
| with open(args.output, "w", encoding="utf-8") as f: | ||
| f.write("@echo off\n") | ||
| f.write(f"rem Cherry-pick {args.label} commits\n") | ||
| f.write("rem Sorted by merge time (oldest first)\n\n") | ||
|
|
||
| for pr in prs: | ||
| number = pr["number"] | ||
| title = pr["title"] | ||
| safe_title = title.replace("\n", " ") | ||
|
|
||
| if not pr.get("mergeCommit"): | ||
| print(f"Warning: PR #{number} has no merge commit OID. Skipping.", file=sys.stderr) | ||
| continue | ||
|
|
||
| oid = pr["mergeCommit"]["oid"] | ||
| f.write(f"rem PR {number}: {safe_title}\n") | ||
| f.write(f"git cherry-pick {oid}\n\n") | ||
| commit_count += 1 | ||
|
|
||
| print(f"Generated {args.output} with {commit_count} commits.") | ||
|
|
||
| # Write to markdown file. You can use it as the pull request description. | ||
| md_output = "cherry_pick_pr_description.md" | ||
| with open(md_output, "w", encoding="utf-8") as f: | ||
| f.write("This cherry-picks the following commits for the release:\n") | ||
| for pr in prs: | ||
| if not pr.get("mergeCommit"): | ||
| continue | ||
| number = pr["number"] | ||
| f.write(f"- #{number}\n") | ||
|
|
||
| print(f"Generated {md_output} with {commit_count} commits.") | ||
|
|
||
| # Check for potential missing dependencies | ||
| print("\nChecking for potential missing dependencies (conflicts)...") | ||
|
|
||
| # Collect OIDs being cherry-picked | ||
| cherry_pick_oids = set() | ||
| for pr in prs: | ||
| if pr.get("mergeCommit"): | ||
| cherry_pick_oids.add(pr["mergeCommit"]["oid"]) | ||
|
|
||
| for pr in prs: | ||
| if not pr.get("mergeCommit"): | ||
| continue | ||
|
|
||
| oid = pr["mergeCommit"]["oid"] | ||
| number = pr["number"] | ||
|
|
||
| # Get files changed by this commit | ||
| try: | ||
| res = subprocess.run( | ||
| ["git", "diff-tree", "--no-commit-id", "--name-only", "-r", oid], | ||
| capture_output=True, | ||
| text=True, | ||
| check=True, | ||
| ) | ||
| files = res.stdout.strip().splitlines() | ||
| except subprocess.CalledProcessError as e: | ||
| print(f"Error getting changed files for {oid}: {e}", file=sys.stderr) | ||
| continue | ||
|
|
||
| # For each file, find commits that modified it between the target branch and the cherry-picked commit. | ||
| # Deduplicate warnings: group affected files by missing commit. | ||
| # missing_commits maps: missing_commit_oid -> (title, [list of affected files]) | ||
| missing_commits = defaultdict(lambda: ("", [])) | ||
|
tianleiwu marked this conversation as resolved.
Outdated
|
||
| for filepath in files: | ||
| try: | ||
| res = subprocess.run( | ||
| ["git", "log", oid, "--not", args.branch, "--format=%H %s", "--", filepath], | ||
| capture_output=True, | ||
| text=True, | ||
| check=True, | ||
| ) | ||
| for line in res.stdout.strip().splitlines(): | ||
| parts = line.split(" ", 1) | ||
| c = parts[0] | ||
| title = parts[1] if len(parts) > 1 else "" | ||
|
|
||
| if c == oid: | ||
| continue | ||
| if c not in cherry_pick_oids: | ||
| existing_title, existing_files = missing_commits[c] | ||
| if not existing_title: | ||
| existing_title = title | ||
| existing_files.append(filepath) | ||
| missing_commits[c] = (existing_title, existing_files) | ||
|
|
||
| except subprocess.CalledProcessError as e: | ||
| print(f"Error checking history for {filepath}: {e}", file=sys.stderr) | ||
| continue | ||
|
|
||
| # Print deduplicated warnings | ||
| for missing_oid, (title, affected_files) in missing_commits.items(): | ||
| files_str = ", ".join(affected_files) | ||
| print( | ||
| f"WARNING: PR #{number} ({oid}) depends on commit {missing_oid} ({title}) " | ||
| f"which is not in the cherry-pick list. Affected files: {files_str}" | ||
|
tianleiwu marked this conversation as resolved.
Outdated
|
||
| ) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| main() | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.