Fix WebGPU MoE swiglu_limit (default to infinity)#27221
Merged
hanbitmyths merged 1 commit intomicrosoft:mainfrom Feb 3, 2026
Merged
Fix WebGPU MoE swiglu_limit (default to infinity)#27221hanbitmyths merged 1 commit intomicrosoft:mainfrom
hanbitmyths merged 1 commit intomicrosoft:mainfrom
Conversation
tianleiwu
approved these changes
Feb 2, 2026
Contributor
|
/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
guschmue
approved these changes
Feb 2, 2026
Contributor
|
nice catch! |
tianleiwu
pushed a commit
that referenced
this pull request
Feb 3, 2026
### Description According to https://github.com/microsoft/onnxruntime/blob/main/docs/ContribOperators.md#commicrosoftmoe, > swiglu_limit : float The limit used to clamp in SwiGLU. No clamp when limit is not provided. However, currently, the default is set to 0, meaning we clamp to 0 if no limit is provided. ### Motivation and Context Fixes #27220. See there for bug description and reproduction. Hoping to get this in before 1.24.0 releases. cc @guschmue
|
Yes this is really nice haha :D |
tianleiwu
added a commit
that referenced
this pull request
Feb 3, 2026
Cherry-pick round 1 for 1.24.1 release: #27157: [Fix: Replace pkg_resources with importlib.metadata in machine_info.py](40469f0) #27124: [Remove x86 from nuget (#27124)](5c98f5c) #26390: [[MLAS] Fix rotary interleaved NEON kernel](536c6c9) #27215: [Fix Conv LHS packing padding/uninitialized ptrs V2](62a3890) #27221: [Fix WebGPU MoE swiglu_limit (default to infinity)](98b6ce9) #26994: [Fix for https://github.com/microsoft/onnxruntime/issues/25145](https://github.com/microsoft/onnxruntime/commit/bce7b4faca24ae2ae279ab8fa2de637a46e7f45b) --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Hariharan Seshadri <shariharan91@gmail.com> Co-authored-by: Joshua Lochner <admin@xenova.com> Co-authored-by: umangb-09 <umangb@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to https://github.com/microsoft/onnxruntime/blob/main/docs/ContribOperators.md#commicrosoftmoe,
However, currently, the default is set to 0, meaning we clamp to 0 if no limit is provided.
Motivation and Context
Fixes #27220. See there for bug description and reproduction.
Hoping to get this in before 1.24.0 releases. cc @guschmue