-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[webgpu] make PIX frame generator per session #26873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qjia7
previously approved these changes
Dec 29, 2025
guschmue
previously approved these changes
Dec 29, 2025
Contributor
|
CI not happy: 'enable_pix_capture': is not a member of 'onnxruntime::webgpu::WebGpuContextConfig' |
Copilot AI
added a commit
that referenced
this pull request
Dec 29, 2025
Co-authored-by: fs-eire <7679871+fs-eire@users.noreply.github.com>
…ExecutionProviderConfig (#26877) ### Description PR #26873 moved `enable_pix_capture` from `WebGpuContextConfig` to `WebGpuExecutionProviderConfig` but didn't update `webgpu_provider_factory.cc` to parse the config option into the correct struct. **Changes:** - Move PIX capture config parsing from `ParseWebGpuContextConfig()` to `ParseEpConfig()` - Update logging to use the correct config struct (`webgpu_ep_config.enable_pix_capture`) ### Motivation and Context Build was failing with: ``` 'enable_pix_capture': is not a member of 'onnxruntime::webgpu::WebGpuContextConfig' ``` This completes the refactoring in #26873 which makes the PIX frame generator per-session instead of per-WebGpuContext. <!-- START COPILOT CODING AGENT SUFFIX --> <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > Please help me to fix the build break for #26873. </details> <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: eserscor <erscor@microsoft.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: fs-eire <7679871+fs-eire@users.noreply.github.com>
qjia7
approved these changes
Dec 30, 2025
alex-spacemit
pushed a commit
to spacemit-com/onnxruntime
that referenced
this pull request
Jan 20, 2026
### Description As a following-up of microsoft#26855, this PR changes the PIX fram generator from per-WebGpuContext to per inference session, to support more flexible control for performance diagnositcs. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. -->
alex-spacemit
pushed a commit
to spacemit-com/onnxruntime
that referenced
this pull request
Jan 27, 2026
### Description As a following-up of microsoft#26855, this PR changes the PIX fram generator from per-WebGpuContext to per inference session, to support more flexible control for performance diagnositcs. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a following-up of #26855, this PR changes the PIX fram generator from per-WebGpuContext to per inference session, to support more flexible control for performance diagnositcs.
Motivation and Context