[NV TensorRT RTX EP] Fix external tensorrt_plugins load path by keshavv27 · Pull Request #26814 · microsoft/onnxruntime

keshavv27 · 2025-12-17T04:49:20Z

Description

Load tensorrt_plugin library from EP library location instead of runtime library location.

Motivation and Context

Plugin library was being searched for in core ONNX Runtime library path, and not the EP library path. These paths are separate in case of WinML workflow.

anskumar01 · 2025-12-17T05:03:54Z

@devang-ml , @chilo-ms , can you please review and merge this PR? It is required for current EP drop

Copilot

Pull request overview

This PR fixes the external tensorrt_plugins library loading path to use the EP (Execution Provider) library location instead of the runtime library location. This addresses an issue where the plugin library was being incorrectly searched for in the core ONNX Runtime library path, which is separate from the EP library path in WinML workflows.

Key changes:

Introduced a new GetEPLibraryDirectory() helper function to determine the EP library's directory path
Updated the plugin loading logic to use the EP library directory instead of the runtime path
Updated the error log message to reflect the correct search location

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-18T19:58:33Z

onnxruntime/core/providers/nv_tensorrt_rtx/nv_execution_provider_custom_ops.cc

+  if (last_slash != std::string::npos) {
+    return PathString(so_path.substr(0, last_slash + 1));
+  }
+  return PathString(so_path);


On line 70, when last_slash is not found (npos), the function returns the entire path string. This would be incorrect because if there's no slash in the path, the function should return an empty string instead of the full path, since the purpose is to return the directory containing the library, not the library path itself. Consider returning an empty PathString when last_slash == std::string::npos.

Copilot · 2025-12-18T19:58:34Z

onnxruntime/core/providers/nv_tensorrt_rtx/nv_execution_provider_custom_ops.cc

+  // Get handle to the DLL executing this code
+  if (!GetModuleHandleExW(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS |
+                              GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT,
+                          reinterpret_cast<LPCWSTR>(&GetEPLibraryDirectory),


The reinterpret_cast to LPCWSTR is incorrect. GetModuleHandleExW expects the lpModuleName parameter to be a string (LPCWSTR) when GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS is not used, but when this flag is set, it expects a raw address (LPCVOID). The address of the function should be cast to LPCWSTR without going through the pointer, i.e., reinterpret_cast(GetEPLibraryDirectory) should be used, not reinterpret_cast(&GetEPLibraryDirectory).

Copilot · 2025-12-18T19:58:34Z

onnxruntime/core/providers/nv_tensorrt_rtx/nv_execution_provider_custom_ops.cc

+  if (lastSlash != std::wstring::npos) {
+    return PathString(path.substr(0, lastSlash + 1));
+  }
+  return PathString(path);


On line 56, when lastSlash is not found (npos), the function returns the entire path string. This would be incorrect because if there's no slash in the path, the function should return an empty string instead of the full path, since the purpose is to return the directory containing the library, not the library path itself. Consider returning an empty PathString when lastSlash == std::wstring::npos.

onnxruntime/core/providers/nv_tensorrt_rtx/nv_execution_provider_custom_ops.cc

yuslepukhin

🕐

yuslepukhin · 2025-12-22T18:21:10Z

Please, comment and resolve Copilot issues.

yuslepukhin

chilo-ms · 2026-01-14T17:19:46Z

/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline

azure-pipelines · 2026-01-14T17:20:06Z

Azure Pipelines successfully started running 4 pipeline(s).

…ft#26814) ### Description  Load tensorrt_plugin library from EP library location instead of runtime library location. ### Motivation and Context  Plugin library was being searched for in core ONNX Runtime library path, and not the EP library path. These paths are separate in case of WinML workflow.

### Description  Load tensorrt_plugin library from EP library location instead of runtime library location. ### Motivation and Context  Plugin library was being searched for in core ONNX Runtime library path, and not the EP library path. These paths are separate in case of WinML workflow.

| Commit | Commit Title | Author | | :--- | :--- | :--- | | `11dde2d9e` | [NV TensorRT RTX EP] Fix external tensorrt_plugins load path (#26814) | keshavv27 | | `080d96818` | Move model compatibility checks ahead of session initialization (#27037) | adrastogi | | `ec4f6bfa1` | [QNN EP] Fix error messages being logged as VERBOSE instead of ERROR (#24931) | Copilot | | `0432e7125` | perftest: support plugin eps for compile_ep_context (#27121) | Jaskaran Singh Nagi | | `727db0d3d` | Engine compatibility validity API implementation (#26774) | umangb-09 | | `27013522f` | Deprecate transformers model examples (#27156) | Jambay Kinley | | `f83d4d06e` | [QNN-EP] Implement file mapped weights feature (#26952) | quic-calvnguy | --------- Co-authored-by: keshavv27 <165012837+keshavv27@users.noreply.github.com> Co-authored-by: adrastogi <aditya.rastogi@microsoft.com> Co-authored-by: Aditya Rastogi <adityar@ntdev.microsoft.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: vraspar <51386888+vraspar@users.noreply.github.com> Co-authored-by: yuslepukhin <11303988+yuslepukhin@users.noreply.github.com> Co-authored-by: Dmitri Smirnov <yuslepukhin@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dmitri Smirnov <dmitrism@microsoft.com> Co-authored-by: Jaskaran Singh Nagi <jaskaran.singh.nagi@intel.com> Co-authored-by: umangb-09 <umangb@nvidia.com> Co-authored-by: Jambay Kinley <jambaykinley@microsoft.com> Co-authored-by: quic-calvnguy <quic_calvnguy@quicinc.com> Co-authored-by: quic_calvnguy <quic_calvnguy@quic_inc.com>

keshavv27 added 3 commits December 17, 2025 10:13

Fix TRT RTX plugin load path

fc2e203

Add header files, fix error output

ab26c6f

fix linting

fe607b4

yuslepukhin requested a review from Copilot December 18, 2025 19:55

Copilot started reviewing on behalf of yuslepukhin December 18, 2025 19:56 View session

Copilot AI reviewed Dec 18, 2025

View reviewed changes

yuslepukhin reviewed Dec 18, 2025

View reviewed changes

onnxruntime/core/providers/nv_tensorrt_rtx/nv_execution_provider_custom_ops.cc Outdated Show resolved Hide resolved

yuslepukhin reviewed Dec 18, 2025

View reviewed changes

onnxruntime/core/providers/nv_tensorrt_rtx/nv_execution_provider_custom_ops.cc Outdated Show resolved Hide resolved

yuslepukhin reviewed Dec 18, 2025

View reviewed changes

onnxruntime/core/providers/nv_tensorrt_rtx/nv_execution_provider_custom_ops.cc Outdated Show resolved Hide resolved

yuslepukhin requested changes Dec 18, 2025

View reviewed changes

use pathstring ctor, abstract fn and platform defs

aedf409

yuslepukhin approved these changes Jan 5, 2026

View reviewed changes

chilo-ms closed this Jan 14, 2026

chilo-ms reopened this Jan 14, 2026

yuslepukhin merged commit 11dde2d into microsoft:main Jan 15, 2026
99 of 100 checks passed

adrianlizarraga added the release:1.24.0 label Jan 24, 2026

tianleiwu mentioned this pull request Jan 27, 2026

ORT 1.24.0 release cherry pick round 3 #27168

Merged

tianleiwu added cherry-picked Cherry-picked for a cherrypicks branch and removed release:1.24.0 labels Jan 29, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NV TensorRT RTX EP] Fix external tensorrt_plugins load path#26814

[NV TensorRT RTX EP] Fix external tensorrt_plugins load path#26814
yuslepukhin merged 4 commits intomicrosoft:mainfrom
keshavv27:keshavv/fix_plugin_load_path

keshavv27 commented Dec 17, 2025

Uh oh!

anskumar01 commented Dec 17, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 18, 2025

Uh oh!

Copilot AI Dec 18, 2025

Uh oh!

Copilot AI Dec 18, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yuslepukhin left a comment

Uh oh!

yuslepukhin commented Dec 22, 2025

Uh oh!

yuslepukhin left a comment

Uh oh!

chilo-ms commented Jan 14, 2026

Uh oh!

azure-pipelines bot commented Jan 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

keshavv27 commented Dec 17, 2025

Description

Motivation and Context

Uh oh!

anskumar01 commented Dec 17, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yuslepukhin left a comment

Choose a reason for hiding this comment

Uh oh!

yuslepukhin commented Dec 22, 2025

Uh oh!

yuslepukhin left a comment

Choose a reason for hiding this comment

Uh oh!

chilo-ms commented Jan 14, 2026

Uh oh!

azure-pipelines bot commented Jan 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants