Skip to content

coreml: Add a few missing operators#26462

Merged
snnn merged 2 commits into
microsoft:mainfrom
borg323:coreml-missing-lc0-ops
Oct 31, 2025
Merged

coreml: Add a few missing operators#26462
snnn merged 2 commits into
microsoft:mainfrom
borg323:coreml-missing-lc0-ops

Conversation

@borg323
Copy link
Copy Markdown
Contributor

@borg323 borg323 commented Oct 31, 2025 •
edited
Loading

Description

Adds Elu, Exp and Softplus to coreml.

Motivation and Context

We use them in LeelaChessZero.

@borg323
Copy link
Copy Markdown
Contributor Author

borg323 commented Oct 31, 2025

@microsoft-github-policy-service agree

@borg323 borg323 mentioned this pull request Oct 31, 2025
Merged
@snnn
Copy link
Copy Markdown
Contributor

snnn commented Oct 31, 2025

Cool project!

@snnn
Copy link
Copy Markdown
Contributor

snnn commented Oct 31, 2025

Some tests failed:

 Initialize failed but expected success: Error compiling model: Failed to parse the model specification. Error: Unable to parse ML Program: in operation node1: Required param 'epsilon' is missing

@borg323
Copy link
Copy Markdown
Contributor Author

borg323 commented Oct 31, 2025

I removed Log for now as it was for future extensions, will make a better implementation when we need it.

@snnn snnn merged commit 002539f into microsoft:main Oct 31, 2025
92 checks passed
@borg323 borg323 deleted the coreml-missing-lc0-ops branch November 1, 2025 00:35
This was referenced Apr 22, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@snnn snnn snnn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@borg323 @snnn