Address a bug when a number of meminfos return by SessionGetOutputCount() always for inputs #25988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the GetInputOutputMemoryInfo function where the function was hardcoded to always retrieve input memory info instead of using the caller-specified type parameter.
- Replaces hardcoded constant with the
typeparameter to respect caller's intent - Ensures the function behaves correctly for both input and output memory info requests
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
adrianlizarraga
approved these changes
Sep 8, 2025
Contributor
|
Should we add a unit test? |
Member
Author
|
It is getting covered in my next PR, that's how I found it. |
snnn
pushed a commit
that referenced
this pull request
Sep 9, 2025
…nt() always for inputs (#25988) ### Description <!-- Describe your changes. --> Use the argument passed instead of a constant. ### Motivation and Context This is a bug
jywu-msft
pushed a commit
that referenced
this pull request
Sep 10, 2025
Contributor
|
This PR has been cherry-picked into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the argument passed instead of a constant.
Motivation and Context
This is a bug