Fix transpose of empty initializers called from constant folding#25922
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a crash in ConstantFolding when attempting to transpose constant empty initializers by adding a guard condition to skip the transpose operation for empty tensors.
- Added guard condition to skip transpose operation when tensor size is 0
- Added test case to verify the fix works correctly for empty initializer transpose scenarios
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| onnxruntime/test/optimizer/graph_transform_test.cc | Adds test case to verify constant folding doesn't crash on empty initializer transpose |
| onnxruntime/core/optimizer/transpose_optimization/ort_optimizer_api_impl.cc | Adds size check guard to prevent transpose operation on empty tensors |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
justinchuby
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ConstantFolding crashes when a constant empty initializer is transposed.
Motivation and Context
This rare case happened when converting a LLM into onnx with static shape.