[Web] Magic import comment missing for Vite (/* @vite-ignore */) #25919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree |
fs-eire
reviewed
Sep 2, 2025
fs-eire
reviewed
Sep 2, 2025
Contributor
fs-eire
left a comment
fs-eire
left a comment
There was a problem hiding this comment.
thank you for the contribution! please resolve the comments
Contributor
|
please also modify implementation of function |
Contributor
Author
|
Thanks @fs-eire, I have made the requested changes. |
Contributor
|
please fix the build failure by running |
Contributor
Author
|
@fs-eire formatting was applied. |
Contributor
|
/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 5 pipeline(s). |
fs-eire
approved these changes
Sep 5, 2025
Contributor
Author
|
Hi @fs-eire, I was just wondering if there's anything else I can do, or what would the next steps look like? |
Contributor
|
sorry for the late response - looks like the code need to update to latest main branch so that required pipelines can be triggered |
Contributor
Author
|
Thanks @fs-eire, I just rebased on latest |
Contributor
|
/azp run Windows GPU Doc Gen CI Pipeline, Windows ARM64 QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Linux QNN CI Pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Contributor
|
/azp run Windows GPU Doc Gen CI Pipeline, Windows ARM64 QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Linux QNN CI Pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
JonathanC-ARM
pushed a commit
to JonathanC-ARM/onnxruntime
that referenced
this pull request
Oct 24, 2025
…rosoft#25919) ### Description This is a small change that includes the insertion of the `/* @vite-ignore */` magic comment within the `build.ts` `postProcess` function, alongside `/* webpackIgnore:true */`, for dynamic imports. `/* @vite-ignore */` suppresses a Vite warning: > The above dynamic import cannot be analyzed by Vite. See https://github.com/rollup/plugins/tree/master/packages/dynamic-import-vars#limitations for supported dynamic import formats. If this is intended to be left as-is, you can use the /* @vite-ignore */ comment inside the import() call to suppress this warning. , and does not change other behaviour. Note that it must be included as a separate, distinct comment to match the [regexp](https://github.com/vitejs/vite/blob/bcc31449c0c4f852ccb1eedda1842bc7ded23d01/packages/vite/src/node/plugins/importAnalysis.ts#L88). ### Motivation and Context Resolves microsoft#25918. The Vite magic comment should be included because the dynamic imports are intended 'to be left as-is', and the warning cannot otherwise be disabled by an end-user (myself in an Angular project).
fs-eire
pushed a commit
that referenced
this pull request
Oct 24, 2025
) ### Description This is a small change that includes the insertion of the `/* @vite-ignore */` magic comment within the `build.ts` `postProcess` function, alongside `/* webpackIgnore:true */`, for dynamic imports. `/* @vite-ignore */` suppresses a Vite warning: > The above dynamic import cannot be analyzed by Vite. See https://github.com/rollup/plugins/tree/master/packages/dynamic-import-vars#limitations for supported dynamic import formats. If this is intended to be left as-is, you can use the /* @vite-ignore */ comment inside the import() call to suppress this warning. , and does not change other behaviour. Note that it must be included as a separate, distinct comment to match the [regexp](https://github.com/vitejs/vite/blob/bcc31449c0c4f852ccb1eedda1842bc7ded23d01/packages/vite/src/node/plugins/importAnalysis.ts#L88). ### Motivation and Context Resolves #25918. The Vite magic comment should be included because the dynamic imports are intended 'to be left as-is', and the warning cannot otherwise be disabled by an end-user (myself in an Angular project).
quic-tirupath
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Oct 27, 2025
…rosoft#25919) ### Description This is a small change that includes the insertion of the `/* @vite-ignore */` magic comment within the `build.ts` `postProcess` function, alongside `/* webpackIgnore:true */`, for dynamic imports. `/* @vite-ignore */` suppresses a Vite warning: > The above dynamic import cannot be analyzed by Vite. See https://github.com/rollup/plugins/tree/master/packages/dynamic-import-vars#limitations for supported dynamic import formats. If this is intended to be left as-is, you can use the /* @vite-ignore */ comment inside the import() call to suppress this warning. , and does not change other behaviour. Note that it must be included as a separate, distinct comment to match the [regexp](https://github.com/vitejs/vite/blob/bcc31449c0c4f852ccb1eedda1842bc7ded23d01/packages/vite/src/node/plugins/importAnalysis.ts#L88). ### Motivation and Context Resolves microsoft#25918. The Vite magic comment should be included because the dynamic imports are intended 'to be left as-is', and the warning cannot otherwise be disabled by an end-user (myself in an Angular project).
naomiOvad
pushed a commit
to naomiOvad/onnxruntime
that referenced
this pull request
Nov 2, 2025
…rosoft#25919) ### Description This is a small change that includes the insertion of the `/* @vite-ignore */` magic comment within the `build.ts` `postProcess` function, alongside `/* webpackIgnore:true */`, for dynamic imports. `/* @vite-ignore */` suppresses a Vite warning: > The above dynamic import cannot be analyzed by Vite. See https://github.com/rollup/plugins/tree/master/packages/dynamic-import-vars#limitations for supported dynamic import formats. If this is intended to be left as-is, you can use the /* @vite-ignore */ comment inside the import() call to suppress this warning. , and does not change other behaviour. Note that it must be included as a separate, distinct comment to match the [regexp](https://github.com/vitejs/vite/blob/bcc31449c0c4f852ccb1eedda1842bc7ded23d01/packages/vite/src/node/plugins/importAnalysis.ts#L88). ### Motivation and Context Resolves microsoft#25918. The Vite magic comment should be included because the dynamic imports are intended 'to be left as-is', and the warning cannot otherwise be disabled by an end-user (myself in an Angular project).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a small change that includes the insertion of the
/* @vite-ignore */magic comment within thebuild.tspostProcessfunction, alongside/* webpackIgnore:true */, for dynamic imports./* @vite-ignore */suppresses a Vite warning:, and does not change other behaviour. Note that it must be included as a separate, distinct comment to match the regexp.
Motivation and Context
Resolves #25918. The Vite magic comment should be included because the dynamic imports are intended 'to be left as-is', and the warning cannot otherwise be disabled by an end-user (myself in an Angular project).