Skip to content

Conversation

@psakhamoori
Copy link
Contributor

Cherry-pick MiGraphX EP fixes from upstream for rel-1.23.0

This PR cherry-picks three critical fixes for the MiGraphX Execution Provider:

  1. Fix compilation after cherry-picking from win-onnxruntime ([MIGraphX EP] Fix compilation after cherry-picking from win-onnxruntime #25516)

    • Adds ORT_UNUSED_PARAMETER(num_devices) to fix unused parameter warning
    • Corrects struct usage in CreateIExecutionProvider method
  2. Fix CreateExecutionProviderFactory with correct struct and change vendor_id ([MIGraphX EP] Fix CreateExecutionProviderFactory with correct struct and change vendor_id #25625)

    • Updates vendor_id from 0x1002 to 0x9999 to allow DML EP to be default
    • Ensures proper device ordering in provider_policy_context.cc
  3. Update OrtEpFactory in MiGraphX EP (Update OrtEpFactory in MiGraphX EP  #25567)

    • Adds complete OrtEpFactory infrastructure for auto EP selection
    • Implements all required factory methods with noexcept specifiers
    • Sets ort_version_supported to ORT_API_VERSION
    • Enables MiGraphX/AMDGPU EP integration with hardware device detection

These fixes ensure MiGraphX EP builds correctly and integrates properly with
the ORT execution provider selection framework in the 1.23.0 release.

Cherry-picked commits:

apwojcik and others added 3 commits August 5, 2025 16:11
…me (microsoft#25516)

After cherry-picking from win-onnxruntime (microsoft#25481), the MIGraphX EP
stopped compiling on the main branch.
…and change vendor_id (microsoft#25625)

This fixes the CreateIExecutionProvider for MIGraphX EP when calling
CreateExecutionProviderFactory, using OrtMIGraphXProviderOptions instead
of ProviderOptions.
Also changes the vendor_id so that OrderDevices in
provider_policy_context.cc will default dml ep when ep_policy is set to
GPU. Will update pending more changes to MIGraphX EP.

Co-authored-by: ozhang <[email protected]>
### Description
Update OrtEpFactory in new EPs to add allocator, data transfer and
stream stubs.

### Motivation and Context
@psakhamoori
Copy link
Contributor Author

@nieubank Please help review this commit

This is to address MiGraphX Compilation errors with below commits cherry-picked

Cherry-picked commits:

@psakhamoori
Copy link
Contributor Author

@adrianlizarraga @skottmckay

Please help approve this PR

@fs-eire fs-eire changed the title Rel 123 with migraphx compilation fix's Cherry-pick MiGraphX EP fixes from upstream for rel-1.23.0 Aug 6, 2025
Incorporates change from PR microsoft#25677 to add vendor ID check (0x1002)
in GetSupportedDevicesImpl to ensure MiGraphX EP only supports
AMD hardware devices.

Co-authored-by: Owen Zhang <[email protected]>
@psakhamoori psakhamoori force-pushed the rel-123-with-migraphx-fix branch from 343780f to 8346646 Compare August 7, 2025 00:04
@nieubank nieubank merged commit e41b4b9 into microsoft:rel-1.23.0 Aug 7, 2025
62 checks passed
@snnn snnn mentioned this pull request Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants