Skip to content

Upgrade nodejs to 22 #25498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snnn merged 2 commits into from
Jul 23, 2025
Merged

Upgrade nodejs to 22 #25498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e6de32
Upgrade nodejs to 22
Jul 22, 2025
1856bf7
Update Dockerfile.manylinux2_28_webgpu
Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tools/ci_build/github/linux/docker/Dockerfile.manylinux2_28_webgpu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ FROM onnxruntimebuildcache.azurecr.io/internal/azureml/onnxruntime/build/cpu_x64
ENV JAVA_HOME=/usr/lib/jvm/msopenjdk-17

#Install Vulkan and RPM Fusion for NVIDIA drivers (UBI8/RHEL8)
RUN dnf install -y \
https://download1.rpmfusion.org/free/el/rpmfusion-free-release-8.noarch.rpm \
https://download1.rpmfusion.org/nonfree/el/rpmfusion-nonfree-release-8.noarch.rpm && \
dnf install -y xorg-x11-drv-nvidia akmod-nvidia vulkan vulkan-tools mesa-vulkan-drivers
#RUN dnf install -y \
# https://download1.rpmfusion.org/free/el/rpmfusion-free-release-8.noarch.rpm \
# https://download1.rpmfusion.org/nonfree/el/rpmfusion-nonfree-release-8.noarch.rpm && \
# dnf install -y xorg-x11-drv-nvidia akmod-nvidia vulkan vulkan-tools mesa-vulkan-drivers

# TODO: Currently this Dockerfile works only for building WebGPU. Need to make it also support running WebGPU tests.

Expand Down
5 changes: 2 additions & 3 deletions tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@
echo "Downloading $uri"
# Use aria2c if available, otherwise use curl
if command -v aria2c > /dev/null; then
aria2c -q -d "$(dirname $path)" -o "$(basename $path)" "$uri"

Check warning on line 30 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / Optional Lint 

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting.

Raw Output:
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:30:52: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check warning on line 30 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / Optional Lint 

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting.

Raw Output:
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:30:29: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
else
curl "$uri" -sSL --retry $download_retries --retry-delay $retry_wait_time_seconds --create-dirs -o "$path" --fail

Check warning on line 32 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / Optional Lint 

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting.

Raw Output:
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:32:62: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check warning on line 32 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / Optional Lint 

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting.

Raw Output:
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:32:30: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
fi

return $?
Expand All @@ -49,9 +49,8 @@
else
NODEJS_ARCH=$CPU_ARCH
fi
# The EOL for nodejs v18.17.1 LTS is April 2025
GetFile https://nodejs.org/dist/v18.17.1/node-v18.17.1-linux-${NODEJS_ARCH}.tar.gz /tmp/src/node-v18.17.1-linux-${NODEJS_ARCH}.tar.gz
tar --strip 1 -xf /tmp/src/node-v18.17.1-linux-${NODEJS_ARCH}.tar.gz -C /usr
GetFile https://nodejs.org/dist/v22.17.1/node-v22.17.1-linux-${NODEJS_ARCH}.tar.gz /tmp/src/node-v22.17.1-linux-${NODEJS_ARCH}.tar.gz

Check warning on line 52 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / Optional Lint 

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting.

Raw Output:
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:52:113: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check warning on line 52 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / Optional Lint 

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting.

Raw Output:
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:52:62: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
tar --strip 1 -xf /tmp/src/node-v22.17.1-linux-${NODEJS_ARCH}.tar.gz -C /usr

Check warning on line 53 in tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / Optional Lint 

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting.

Raw Output:
./tools/ci_build/github/linux/docker/inference/aarch64/default/cpu/scripts/install_deps.sh:53:48: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

cd /
rm -rf /tmp/src
5 changes: 2 additions & 3 deletions tools/ci_build/github/linux/docker/inference/x86_64/default/cpu/scripts/install_deps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@
echo "File '$path' already exists. Skipping download"
return 0
else
rm -rf $path

Check warning on line 17 in tools/ci_build/github/linux/docker/inference/x86_64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / Optional Lint 

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting.

Raw Output:
./tools/ci_build/github/linux/docker/inference/x86_64/default/cpu/scripts/install_deps.sh:17:14: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
fi
fi

if [[ -f $uri ]]; then
echo "'$uri' is a file path, copying file to '$path'"
cp $uri $path

Check warning on line 23 in tools/ci_build/github/linux/docker/inference/x86_64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / Optional Lint 

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting.

Raw Output:
./tools/ci_build/github/linux/docker/inference/x86_64/default/cpu/scripts/install_deps.sh:23:13: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)

Check warning on line 23 in tools/ci_build/github/linux/docker/inference/x86_64/default/cpu/scripts/install_deps.sh

View workflow job for this annotation

GitHub Actions / Optional Lint 

[shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting.

Raw Output:
./tools/ci_build/github/linux/docker/inference/x86_64/default/cpu/scripts/install_deps.sh:23:8: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
return $?
fi

Expand Down Expand Up @@ -49,9 +49,8 @@
else
NODEJS_ARCH=$CPU_ARCH
fi
# The EOL for nodejs v18.17.1 LTS is April 2025
GetFile https://nodejs.org/dist/v18.17.1/node-v18.17.1-linux-${NODEJS_ARCH}.tar.gz /tmp/src/node-v18.17.1-linux-${NODEJS_ARCH}.tar.gz
tar --strip 1 -xf /tmp/src/node-v18.17.1-linux-${NODEJS_ARCH}.tar.gz -C /usr
GetFile https://nodejs.org/dist/v22.17.1/node-v22.17.1-linux-${NODEJS_ARCH}.tar.gz /tmp/src/node-v22.17.1-linux-${NODEJS_ARCH}.tar.gz
tar --strip 1 -xf /tmp/src/node-v22.17.1-linux-${NODEJS_ARCH}.tar.gz -C /usr

cd /
rm -rf /tmp/src
5 changes: 2 additions & 3 deletions tools/ci_build/github/linux/docker/inference/x86_64/default/cuda12/scripts/install_deps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,8 @@ elif [[ "$CPU_ARCH" = "aarch64" ]]; then
else
NODEJS_ARCH=$CPU_ARCH
fi
# The EOL for nodejs v18.17.1 LTS is April 2025
GetFile https://nodejs.org/dist/v18.17.1/node-v18.17.1-linux-${NODEJS_ARCH}.tar.gz /tmp/src/node-v18.17.1-linux-${NODEJS_ARCH}.tar.gz
tar --strip 1 -xf /tmp/src/node-v18.17.1-linux-${NODEJS_ARCH}.tar.gz -C /usr
GetFile https://nodejs.org/dist/v22.17.1/node-v22.17.1-linux-${NODEJS_ARCH}.tar.gz /tmp/src/node-v22.17.1-linux-${NODEJS_ARCH}.tar.gz
tar --strip 1 -xf /tmp/src/node-v22.17.1-linux-${NODEJS_ARCH}.tar.gz -C /usr

cd /
rm -rf /tmp/src
5 changes: 2 additions & 3 deletions tools/ci_build/github/linux/docker/scripts/install_os_deps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,8 @@ if [[ $SYS_LONG_BIT = "64" && "$GLIBC_VERSION" -gt "9" ]]; then
GetFile https://github.com/Kitware/CMake/releases/download/v3.31.5/cmake-3.31.5-Linux-x86_64.tar.gz /tmp/src/cmake-3.31.5-Linux-x86_64.tar.gz
tar -zxf /tmp/src/cmake-3.31.5-Linux-x86_64.tar.gz --strip=1 -C /usr
echo "Installing Node.js"
# The EOL for nodejs v18.17.1 LTS is April 2025
GetFile https://nodejs.org/dist/v18.17.1/node-v18.17.1-linux-x64.tar.xz /tmp/src/node-v18.17.1-linux-x64.tar.xz
tar -xf /tmp/src/node-v18.17.1-linux-x64.tar.xz --strip=1 -C /usr
GetFile https://nodejs.org/dist/v22.17.1/node-v22.17.1-linux-x64.tar.xz /tmp/src/node-v22.17.1-linux-x64.tar.xz
tar -xf /tmp/src/node-v22.17.1-linux-x64.tar.xz --strip=1 -C /usr
else
echo "Installing cmake"
GetFile https://github.com/Kitware/CMake/releases/download/v3.31.5/cmake-3.31.5.tar.gz /tmp/src/cmake-3.31.5.tar.gz
Expand Down
1 change: 0 additions & 1 deletion tools/ci_build/github/linux/docker/scripts/manylinux/install_shared_deps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,5 @@ function GetFile {
cd /tmp/src

echo "Installing Node.js"
# The EOL for nodejs v22.17.1 LTS is April 2027
GetFile https://nodejs.org/dist/v22.17.1/node-v22.17.1-linux-x64.tar.gz /tmp/src/node-v22.17.1-linux-x64.tar.gz
tar --strip 1 -xf /tmp/src/node-v22.17.1-linux-x64.tar.gz -C /usr
Loading