[build] optimize search for nodejs in CMake #25466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs-eire
force-pushed
the
fs-eire/try-fix-npm-packaging-pipeline-3
branch
from
e6d5b8e to
d057284
Compare
guschmue
approved these changes
Jul 21, 2025
qti-yuduo
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Aug 8, 2025
### Description optimize search for nodejs in CMake. ### Motivation and Context The default behavior of CMake's `find_program()` is to search `/bin/` folder before `$PATH`. This may cause a very old Node.js to be used.
sanketkaleoss
pushed a commit
to sanketkaleoss/onnxruntime
that referenced
this pull request
Aug 11, 2025
### Description optimize search for nodejs in CMake. ### Motivation and Context The default behavior of CMake's `find_program()` is to search `/bin/` folder before `$PATH`. This may cause a very old Node.js to be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
optimize search for nodejs in CMake.
Motivation and Context
The default behavior of CMake's
find_program()is to search/bin/folder before$PATH. This may cause a very old Node.js to be used.