-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Add default logger to plugin EP CreateEpFactories #25456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default logger to plugin EP CreateEpFactories #25456
Conversation
… outside of an inference session.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a default logger parameter to the CreateEpFactories function, enabling plugin execution providers to log errors outside of inference sessions. The change addresses the need for logging capabilities at the EP factory level rather than only during inference.
- Adds
default_loggerparameter to theCreateEpFactoriesfunction signature - Updates all EP factory implementations to accept and store the default logger
- Modifies the EP library plugin loader to pass the default logger when creating factories
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
include/onnxruntime/core/session/onnxruntime_ep_c_api.h |
Updates the CreateEpApiFactoriesFn typedef to include the default logger parameter |
onnxruntime/core/session/ep_library_plugin.cc |
Modifies the plugin loader to pass the default logger when calling create_fn_ |
onnxruntime/test/autoep/library/example_plugin_ep.cc |
Updates example plugin to accept and pass the default logger parameter |
onnxruntime/test/autoep/library/ep_factory.h |
Adds default logger member and updates constructor signature |
onnxruntime/test/autoep/library/ep_factory.cc |
Implements the updated constructor with default logger initialization |
onnxruntime/core/providers/qnn/qnn_provider_factory.cc |
Updates QNN EP factory to accept and store the default logger |
onnxruntime/core/providers/nv_tensorrt_rtx/nv_provider_factory.cc |
Updates NVIDIA TensorRT RTX EP factory to accept and store the default logger |
onnxruntime/core/providers/cuda/cuda_provider_factory.cc |
Updates CUDA EP factory to accept and store the default logger |
|
#25448 was merged yesterday, so we need update for VitisAI EP |
Update to accomodate changes from #25456
|
Hi there! We haven't cut the release branch for this version yet, so I'm removing the |
### Description <!-- Describe your changes. --> Add default logger to CreateEpFactories so a plugin EP can log errors outside of an inference session. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. -->
Update to accomodate changes from microsoft#25456
### Description <!-- Describe your changes. --> Add default logger to CreateEpFactories so a plugin EP can log errors outside of an inference session. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. -->
Update to accomodate changes from microsoft#25456
Description
Add default logger to CreateEpFactories so a plugin EP can log errors outside of an inference session.
Motivation and Context