Skip to content

Conversation

@skottmckay
Copy link
Contributor

Description

Add default logger to CreateEpFactories so a plugin EP can log errors outside of an inference session.

Motivation and Context

@jywu-msft jywu-msft requested a review from Copilot July 19, 2025 05:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a default logger parameter to the CreateEpFactories function, enabling plugin execution providers to log errors outside of inference sessions. The change addresses the need for logging capabilities at the EP factory level rather than only during inference.

  • Adds default_logger parameter to the CreateEpFactories function signature
  • Updates all EP factory implementations to accept and store the default logger
  • Modifies the EP library plugin loader to pass the default logger when creating factories

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
include/onnxruntime/core/session/onnxruntime_ep_c_api.h Updates the CreateEpApiFactoriesFn typedef to include the default logger parameter
onnxruntime/core/session/ep_library_plugin.cc Modifies the plugin loader to pass the default logger when calling create_fn_
onnxruntime/test/autoep/library/example_plugin_ep.cc Updates example plugin to accept and pass the default logger parameter
onnxruntime/test/autoep/library/ep_factory.h Adds default logger member and updates constructor signature
onnxruntime/test/autoep/library/ep_factory.cc Implements the updated constructor with default logger initialization
onnxruntime/core/providers/qnn/qnn_provider_factory.cc Updates QNN EP factory to accept and store the default logger
onnxruntime/core/providers/nv_tensorrt_rtx/nv_provider_factory.cc Updates NVIDIA TensorRT RTX EP factory to accept and store the default logger
onnxruntime/core/providers/cuda/cuda_provider_factory.cc Updates CUDA EP factory to accept and store the default logger

@jywu-msft jywu-msft merged commit 053ed28 into main Jul 19, 2025
92 of 94 checks passed
@jywu-msft jywu-msft deleted the skottmckay/AddDefaultLoggerToCreateEpFactories branch July 19, 2025 20:12
@jywu-msft
Copy link
Member

#25448 was merged yesterday, so we need update for VitisAI EP
and also for OVEP when that PR lands.

@snnn
Copy link
Contributor

snnn commented Jul 25, 2025

Hi there! We haven't cut the release branch for this version yet, so I'm removing the release:1.23.0 label for now to keep things tidy. Thanks so much for your contribution! We'll make sure this gets included when the release is prepared. 🤖

qti-yuduo pushed a commit to CodeLinaro/onnxruntime that referenced this pull request Aug 8, 2025
### Description
<!-- Describe your changes. -->
Add default logger to CreateEpFactories so a plugin EP can log errors
outside of an inference session.


### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
qti-yuduo pushed a commit to CodeLinaro/onnxruntime that referenced this pull request Aug 8, 2025
sanketkaleoss pushed a commit to sanketkaleoss/onnxruntime that referenced this pull request Aug 11, 2025
### Description
<!-- Describe your changes. -->
Add default logger to CreateEpFactories so a plugin EP can log errors
outside of an inference session.


### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
sanketkaleoss pushed a commit to sanketkaleoss/onnxruntime that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants