Skip to content
Closed
Changes from 2 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
9df0f29
!. added GetVendorIdImpl
ishwar-raut1 Jul 18, 2025
81084a8
!. added Ep name
ishwar-raut1 Jul 18, 2025
12121aa
Update API ReadOpAttr and CreateOpAttr for string type to unblock EPs…
HectorSVC Jul 18, 2025
ff53f92
increase timeout for onnxruntime-ios-packaging-pipeline (#25438)
prathikr Jul 18, 2025
251eeb2
Bump on-headers and compression in /js/react_native/e2e (#25439)
dependabot[bot] Jul 18, 2025
1d00bff
Bump transformers from 4.48.0 to 4.52.1 in /tools/ci_build/requiremen…
dependabot[bot] Jul 18, 2025
f190e70
add webgpu support for GatherBlockQuantized (#25413)
Jul 18, 2025
7f193b1
[VitisAI] Upstream changes from win-ort (#25448)
nieubank Jul 19, 2025
8eea128
[WebNN] Fix some spelling and naming issues (#25433)
Honry Jul 19, 2025
9d11ae2
Plugin EP data transfer and Stream support. (#25254)
skottmckay Jul 19, 2025
033ca86
[NV RTX EP] Set Compute Capability only on Turing architecture (#25446)
keshavv27 Jul 19, 2025
b45edfb
[NvTensorRTRTX EP]Disable Fast GELU operator in base model used for N…
keshavv27 Jul 19, 2025
16701a2
[CANN]Fix issue with negative dynamic tensor shape (#25431)
bachelor-dou Jul 19, 2025
053ed28
Add default logger to plugin EP CreateEpFactories (#25456)
skottmckay Jul 19, 2025
af205c2
[EP ABI] Add documentation for OrtValue and ort_graph_to_proto util (…
adrianlizarraga Jul 19, 2025
1975fba
[QNN EP] Enable Conv Op with "auto_pad" param set as VALID (#25444)
aparmp-quic Jul 21, 2025
3c7a617
[build] optimize search for nodejs in CMake (#25466)
fs-eire Jul 21, 2025
ca45ff2
'QnnEpFactory' should provide a fully-qualified path to the backend (…
mschofie Jul 21, 2025
3dd0d6d
!. added GetVendorIdImpl
ishwar-raut1 Jul 18, 2025
88facb6
!. added Ep name
ishwar-raut1 Jul 18, 2025
9f1a13c
Merge branch 'iraut/VendorIdImpl' of https://github.com/ishwar-raut1/…
ishwar-raut1 Jul 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions onnxruntime/core/providers/nv_tensorrt_rtx/nv_provider_factory.cc
Original file line number Diff line number Diff line change
Expand Up @@ -159,27 +159,34 @@ struct NvTensorRtRtxEpFactory : OrtEpFactory {
const char* ep_name,
OrtHardwareDeviceType hw_type)
: ort_api{ort_api_in}, ep_name{ep_name}, ort_hw_device_type{hw_type} {
ort_version_supported = ORT_API_VERSION;

Copilot AI Jul 18, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code assigns to ort_version_supported but this member variable is not defined in the visible class definition. This will cause a compilation error.

Copilot uses AI. Check for mistakes.
GetName = GetNameImpl;
GetVendor = GetVendorImpl;
GetVersion = GetVersionImpl;
GetVendorId = GetVendorIdImpl;
GetSupportedDevices = GetSupportedDevicesImpl;
CreateEp = CreateEpImpl;
ReleaseEp = ReleaseEpImpl;
}

// Returns the name for the EP. Each unique factory configuration must have a unique name.
// Ex: a factory that supports NPU should have a different than a factory that supports GPU.
static const char* GetNameImpl(const OrtEpFactory* this_ptr) {
static const char* GetNameImpl(const OrtEpFactory* this_ptr) noexcept {
const auto* factory = static_cast<const NvTensorRtRtxEpFactory*>(this_ptr);
return factory->ep_name.c_str();
}

static const char* GetVendorImpl(const OrtEpFactory* this_ptr) {
static const char* GetVendorImpl(const OrtEpFactory* this_ptr) noexcept {
const auto* factory = static_cast<const NvTensorRtRtxEpFactory*>(this_ptr);
return factory->vendor.c_str();
}

static const char* ORT_API_CALL GetVersionImpl(const OrtEpFactory* /*this_ptr*/) noexcept {
static uint32_t GetVendorIdImpl(const OrtEpFactory* this_ptr) noexcept {
const auto* factory = static_cast<const NvTensorRtRtxEpFactory*>(this_ptr);
return factory->vendor_id;

Copilot AI Jul 18, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code references factory->vendor_id but this member variable is not defined in the visible class definition. This will cause a compilation error.

Copilot uses AI. Check for mistakes.
}

static const char* GetVersionImpl(const OrtEpFactory* /*this_ptr*/) noexcept {
return ORT_VERSION;
}

Expand All @@ -194,7 +201,7 @@ struct NvTensorRtRtxEpFactory : OrtEpFactory {
size_t num_devices,
OrtEpDevice** ep_devices,
size_t max_ep_devices,
size_t* p_num_ep_devices) {
size_t* p_num_ep_devices) noexcept {
size_t& num_ep_devices = *p_num_ep_devices;
auto* factory = static_cast<NvTensorRtRtxEpFactory*>(this_ptr);

Expand All @@ -219,16 +226,16 @@ struct NvTensorRtRtxEpFactory : OrtEpFactory {
_In_ size_t /*num_devices*/,
_In_ const OrtSessionOptions* /*session_options*/,
_In_ const OrtLogger* /*logger*/,
_Out_ OrtEp** /*ep*/) {
_Out_ OrtEp** /*ep*/) noexcept {
return onnxruntime::CreateStatus(ORT_INVALID_ARGUMENT, "[NvTensorRTRTX EP] EP factory does not support this method.");
}

static void ReleaseEpImpl(OrtEpFactory* /*this_ptr*/, OrtEp* /*ep*/) {
static void ReleaseEpImpl(OrtEpFactory* /*this_ptr*/, OrtEp* /*ep*/) noexcept {
// no-op as we never create an EP here.
}

const OrtApi& ort_api;
const std::string ep_name;
const std::string ep_name{kNvTensorRTRTXExecutionProvider};

Copilot AI Jul 18, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ep_name member initialization has changed from being set via constructor parameter to a hardcoded constant. This removes flexibility and may break existing code that relies on different EP names for different configurations, contradicting the comment on line 172-173 that states 'Each unique factory configuration must have a unique name.'

Copilot uses AI. Check for mistakes.
const std::string vendor{"NVIDIA"};

// NVIDIA vendor ID. Refer to the ACPI ID registry (search NVIDIA): https://uefi.org/ACPI_ID_List
Expand Down
Loading